[cpp] Avoid write barriers for cpp.Function fields - #13002
Open
Tutez64 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not emit generational GC write barriers for
cpp.Functioninstance fields.With
HXCPP_GC_GENERATIONALenabled, assigning such a field generated anHX_OBJ_WB_SETcall. This macro expects an object-like value with anmPtrmember, butcpp::Functionis a native function-pointer wrapper and does not have one, causing the generated C++ to fail to compile.Fix
Exclude
TCppFunctionfrom GC write-barrier generation while keeping it classified as an object element for the other code paths that rely on that classification.Tests
Added a C++ regression test which:
HXCPP_GC_GENERATIONALcpp.Functioninstance fieldThe targeted misc test passes successfully.
Closes #13001