fix: close calendar when outside mousedown propagation stops#6308
Open
wanxiankai wants to merge 1 commit into
Open
fix: close calendar when outside mousedown propagation stops#6308wanxiankai wants to merge 1 commit into
wanxiankai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: #6292
Problem
The calendar's document-level
mousedownlistener ran during the bubbling phase. Third-party controls such asreact-selectcan stopmousedownpropagation, preventing the outside-click handler from running and leaving the calendar open.Changes
ignoreClass, and listener cleanup behavior.Screenshots
Not applicable; this changes event handling without visual changes.
To reviewers
The regression is covered with an outside button whose React
onMouseDownhandler callsstopPropagation(). The test fails with the previous bubbling listener and passes with capture enabled.Validation completed locally:
yarn prettier:checkyarn type-checkyarn lintyarn test:ci --runInBand --watchman=false --silent(43 suites, 1,487 tests)yarn buildContribution checklist
Closes #6292