feat(dada-pooled): add --gzip for per-sample JSON output (#70)#73
Merged
Conversation
dada-pooled writes per-sample JSON into --output-dir with no way to
request gzip compression, unlike subcommands that write a single file.
Add a --gzip flag that writes each sample as `{sample}.json.gz` and
routes through the existing misc::write_maybe_gz helper. Default output
is unchanged (`{sample}.json`).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70.
Problem
dada-pooledwrites per-sample JSON into--output-dir, so unlike subcommands that write a single file there was no way to request gzip compression of the outputs.Change
--gzipflag ondada-pooled. When set, each sample is written as{sample}.json.gzvia the existingmisc::write_maybe_gzhelper (keys off the.gzextension).{sample}.json.Verification
cargo buildclean.--gzip, outputs are valid gzip and decompress to the expected tagged JSON; without it, plain.jsonas before.Note: for consistency,
dadaanddada-pseudoshare the same directory-output pattern and could get the same flag in a follow-up (also relevant to #72).🤖 Generated with Claude Code