Skip to content

统一管理页面工具栏 下载 按钮文案 #6499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Glavo merged 3 commits into from
Jul 29, 2026
+8 −6
Merged

统一管理页面工具栏 下载 按钮文案 #6499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b80cf42
(37) 业何以天透海拱
CiiLu Jul 25, 2026
acf4fab
更新简体中文翻译，将“下载模组”修改为“下載模組”
Glavo Jul 29, 2026
e58c312
Merge remote-tracking branch 'upstream/main' into catt
Glavo Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/ModListPageSkin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ final class ModListPageSkin extends SkinBase<ModListPage> {
.toList()
)
),
createToolbarButton2(i18n("download"), SVG.DOWNLOAD, skinnable::download),
createToolbarButton2(i18n("mods.download"), SVG.DOWNLOAD, skinnable::download),
createToolbarButton2(i18n("search"), SVG.SEARCH, () -> changeToolbar(searchBar))
);

Expand Down
8 changes: 5 additions & 3 deletions HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/ResourcePackListPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,17 @@
import javafx.scene.layout.StackPane;
import javafx.stage.FileChooser;
import javafx.util.Duration;
import org.jackhuang.hmcl.addon.*;
import org.jackhuang.hmcl.addon.LocalAddonFile;
import org.jackhuang.hmcl.addon.RemoteAddon;
import org.jackhuang.hmcl.addon.RemoteAddonRepository;
import org.jackhuang.hmcl.addon.repository.CurseForgeRemoteAddonRepository;
import org.jackhuang.hmcl.addon.repository.ModrinthRemoteAddonRepository;
import org.jackhuang.hmcl.addon.resourcepack.ResourcePackFile;
import org.jackhuang.hmcl.addon.resourcepack.ResourcePackManager;
import org.jackhuang.hmcl.game.GameInstanceID;
import org.jackhuang.hmcl.game.HMCLGameRepository;
import org.jackhuang.hmcl.setting.SettingsManager;
import org.jackhuang.hmcl.setting.DownloadProviders;
import org.jackhuang.hmcl.setting.SettingsManager;
import org.jackhuang.hmcl.task.Schedulers;
import org.jackhuang.hmcl.task.Task;
import org.jackhuang.hmcl.ui.Controllers;
Expand Down Expand Up @@ -347,7 +349,7 @@ private ResourcePackListPageSkin(ResourcePackListPage control) {
createToolbarButton2(i18n("addon.check_update.button"), SVG.UPDATE, () ->
control.checkUpdates(listView.getItems().stream().map(ResourcePackInfoObject::getFile).toList())
),
createToolbarButton2(i18n("download"), SVG.DOWNLOAD, control::onDownload),
createToolbarButton2(i18n("resourcepack.download"), SVG.DOWNLOAD, control::onDownload),

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add localized resource-pack download labels

Add resourcepack.download to the Spanish, Japanese, Russian, and Ukrainian bundles before using it here. Those shipped bundles contain localized download values but lack this key, so ResourceBundle falls back to the base bundle and the toolbar changes from localized text such as “Descargar” or “ダウンロード” to English “Download” for users of those four languages.

Useful? React with 👍 / 👎.

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the resource-pack button localized

When the UI language is Spanish, Japanese, Russian, or Ukrainian, resourcepack.download is absent from the corresponding locale bundle, so Java's resource-bundle fallback displays the English Download from I18N.properties. The previous download key is translated in every one of those bundles, making this a visible localization regression; add resourcepack.download translations for these locales before switching the toolbar to the specialized key.

Useful? React with 👍 / 👎.

createToolbarButton2(i18n("search"), SVG.SEARCH, () -> changeToolbar(searchBar))
);

Expand Down
2 changes: 1 addition & 1 deletion HMCL/src/main/resources/assets/lang/I18N_zh.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ mods.add.failed=新增模組「%s」失敗。
mods.add.success=成功新增模組「%s」。
mods.add.title=選取要新增的模組檔案
mods.disable=停用
mods.download=模組下載
mods.download=下載模組
mods.download.title=模組下載 - %1s
mods.download.recommend=推薦版本 - Minecraft %1s
mods.empty=沒有模組
Expand Down
2 changes: 1 addition & 1 deletion HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ mods.add.failed=添加模组“%s”失败。\n如遇到问题，你可以点击
mods.add.success=成功添加模组 %s。
mods.add.title=选择要添加的模组文件
mods.disable=禁用
mods.download=模组下载
mods.download=下载模组
mods.download.title=模组下载 - %1s
mods.download.recommend=推荐版本 - Minecraft %1s
mods.empty=没有模组
Expand Down