[Enhancement] 启动器检查更新失败时显示提示 - #6286
Conversation
ToobLac
changed the title
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces error handling for update checks and disables updates if the launcher instance cannot be verified. Specifically, it adds an error property to UpdateChecker to capture update failures, updates SettingsPage to display these errors or hide the update UI if self-verification fails, and adds corresponding localization strings. The review feedback points out a potential issue in UpdateChecker.java where latestVersion could be incorrectly set to null if finalResult is null, as the original null check was omitted in the new error-handling branch, and suggests restoring this check.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/main/SettingsPage.java
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5515aa9e48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4 participants
Uh oh!
There was an error while loading. Please reload this page.