Noprofiles - #16
Open
saulakravitz wants to merge 3 commits into
Open
Conversation
saulakravitz
commented
Apr 5, 2021
Contributor
- Eliminated _profile search
- replaced ad-hoc caching scheme with memcachedb/dalli.
- Got rid of ClientConnections code. Now looks like plan-net and cpcds-ri
added 3 commits
April 2, 2021 14:39
…@client maintenance now follows cpcds-client and plan-net client.
dhill
requested changes
Apr 16, 2021
dhill
left a comment
Collaborator
There was a problem hiding this comment.
Hi Saul,
I believe I resolved the ad hoc caching issue in preparation for the CARIN Connectathon, which went down a different path than what you have proposed here and currently in the master branch. I think the _profile changes and modifications to the authentication are probably fine and can be merged with some attention to the memcache strategy deployed currently in the master branch. Please take a look at that strategy, update accordingly and/or let me know if you have questions or concerns.
Thanks!
Dave
Contributor
Author
|
Are you mixing up cpcds-ri and formulary client?
If I checkout the master branch, I find no reference to dalli, and I find all of my crazy compress/decompress code.
See https://github.com/HL7-DaVinci/pdex-formulary-client/blob/master/app/controllers/application_controller.rb
…________________________________
From: Dave Hill ***@***.***>
Sent: Friday, April 16, 2021 3:57 PM
To: HL7-DaVinci/pdex-formulary-client ***@***.***>
Cc: Saul A Kravitz ***@***.***>; Author ***@***.***>
Subject: [EXT] Re: [HL7-DaVinci/pdex-formulary-client] Noprofiles (#16)
@dhill requested changes on this pull request.
Hi Saul,
I believe I resolved the ad hoc caching issue in preparation for the CARIN Connectathon, which went down a different path than what you have proposed here and currently in the master branch. I think the _profile changes and modifications to the authentication are probably fine and can be merged with some attention to the memcache strategy deployed currently in the master branch. Please take a look at that strategy, update accordingly and/or let me know if you have questions or concerns.
Thanks!
Dave
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#16 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AI36FE5VBCE7A6UCGERXB2LTJCJDPANCNFSM42M2OL5Q>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.