Repository navigation
Conversation
edopao
added this pull request to stack #2935
October 5, 2026 07:23
edopao
force-pushed
the
dace_noview_nested_sdfg
branch
from
October 5, 2026 13:01
d4c4686 to
3b0658d
Compare
edopao
force-pushed
the
dace_noview_nested_sdfg
branch
from
October 5, 2026 13:21
3b0658d to
788525e
Compare
edopao
removed this pull request from stack #2935
October 5, 2026 13:22
Contributor
Author
|
cscs-ci run default |
1 similar comment
Contributor
Author
|
cscs-ci run default |
edopao
force-pushed
the
dace_noview_nested_sdfg
branch
from
October 9, 2026 14:54
1b31304 to
d72f949
Compare
Contributor
Author
|
cscs-ci run default |
1 similar comment
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
The failure in the RoCM CI ( |
Contributor
Author
|
cscs-ci run default |
2 similar comments
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run dace-determinism |
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run dace-determinism |
Contributor
Author
|
cscs-ci run default |
GPUTransformLocalStorage (run with nested_seq=True) sets all StorageType.Default transients inside a GPU map to StorageType.Register. However, variable-length arrays (whose size is not known at compile time, e.g. scan column temporaries) cannot be allocated in registers on GPU — the DaCe code generator emits a call to the host-only dace::aligned_new_array() inside the __global__ kernel, which nvcc rejects. Move such arrays to GPU_Global with the pool allocator instead.
…PU_Global" This reverts commit d72f949.
…on in RemoveAccessNodeCopies RemoveAccessNodeCopies repoints the edges of scan NestedSDFGs at the full output field (e.g. next_w) by merging temporary access nodes. The scan's inner output connector, however, has the domain shape, which is windowed relative to the full field. This made _gt_map_strides_into_nested_sdfg() raise: ValueError: The connector '__gtir_scan_output_x_kplus1' of NestedSDFG 'scan_1' is not equivalent to the data 'next_w' The issue only surfaced with compile_time_domain/compile_time_vertical variants, where the domain bounds are concrete and the pattern matcher can prove the copy chain is a no-op; the default (symbolic) variant does not trigger the pattern. As the docstring of _gt_map_strides_into_nested_sdfg already states, a transformation that connects different data to a connector must restate it. Call restate_nested_sdfg_connector() to adopt the new outer descriptor and shift the memlets inside by the offset of the old domain-sized data within the full field, before propagating strides.
edopao
force-pushed
the
dace_noview_nested_sdfg
branch
from
October 13, 2026 14:51
8c085c6 to
02259e7
Compare
edopao
added this pull request to stack #2945
October 13, 2026 14:57
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run dace-determinism |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICON4Py CI tests pass, see C2SM/icon4py#1471