Skip to content

Fix Bucket Mode Toggle on Pump Covers, and uncap Supply/KeepExact limits on Regulators - #5415

Open
DilithiumThoride wants to merge 2 commits into
1.20.1from
dt/regulator-buckets
Open

Fix Bucket Mode Toggle on Pump Covers, and uncap Supply/KeepExact limits on Regulators#5415
DilithiumThoride wants to merge 2 commits into
1.20.1from
dt/regulator-buckets

Conversation

@DilithiumThoride

@DilithiumThoride DilithiumThoride commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

What

Two (related) changes:

  1. Bucket Mode toggle only alters the increment of the +/- buttons and scrollwheel. But the readout showing current config value always displays as millibuckets, meaning that it looks like bucket mode has no effect.
  2. Fluid Regulators could not be set to SupplyExact or KeepExact values higher than their per-tick transfer limit, severely limiting the usefulness of lower-tier Regulators (and drastically limiting their throughput to only 5% of what it should be). In contrast, Robot Arms have no such limitation on their SE/KE values.

Implementation Details

Bucket Mode toggle now changes the display to show its value as B.MMM. The decimal conversion is only visual, using a StringBuilder to inject a . and a .split() to parse the input; all values are still stored as integer millibuckets.
SE/KE input values are now fully uncapped. This does not break behavior as the existing SE/KE transfer modes would buffer any transfers if the cover couldn't send enough in a single action.

AI Usage

  • [ X ] No AI driven tools were used for this pull request.

Outcome

image

@DilithiumThoride
DilithiumThoride requested a review from a team as a code owner September 11, 2026 03:47
@DilithiumThoride DilithiumThoride added type: bugfix General bug fixes 1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. labels Sep 11, 2026
@github-actions github-actions Bot added the Tests: Passed Game Tests have passed on this PR label Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. Tests: Passed Game Tests have passed on this PR type: bugfix General bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant