Properly defer machine registration (1.21) - #5412
Open
gustovafing wants to merge 8 commits into
Open
Conversation
gustovafing
added this pull request to stack #5411
September 9, 2026 08:28
gustovafing
added
ignore changelog
gustovafing
force-pushed
the
gus/defer-machine-registration
branch
from
September 9, 2026 09:04
96c840f to
eeded09
Compare
github-actions
Bot
added
Tests: Passed
screret
suggested changes
Sep 10, 2026
screret
left a comment
screret
left a comment
Contributor
There was a problem hiding this comment.
Round 1/? (more coming; might PR some changes myself)
screret
suggested changes
Sep 11, 2026
| protected final GTRegistrate registrate; | ||
| protected final String name; | ||
| SELF extends MachineBuilder<DEFINITION, MACHINE, SELF>> | ||
| extends AbstractBuilder<MachineDefinition, DEFINITION, GTRegistrate, SELF> { |
Contributor
There was a problem hiding this comment.
Add the P generic I mentioned instead of disallowing that entirely by hardcoding the parent to GTRegistrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Properly defers machines to the proper registration time, machine builder now returns a machine entry holder, which can be used in a lot of places where machinedefinitions could.
No AI