Clean up AOE data component handling - #5390
Open
screret wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
split aoe definition into 2 indentical components: one for current value and one for max.
This mirrors handling of other similar values in vanilla, like durability & max_damage.
Implementation Details
AI Usage
Outcome
nicer AoE component that doesnt do the job of 2 different things
How Was This Tested
mined blocks with AOE (still works)
made paths with AOE (still works)
fiddled with the AOE config gui (still works)
Additional Information
This section is for screenshots to demonstrate any GUI or rendering changes, or any other additional information that reviewers should be aware of.
Potential Compatibility Issues
Addons using the component may have to change their code.
I don't think anyone has made an addon for 1.21 that does that.