Re-introduce Large Turbine UI lines - #5382
Open
DilithiumThoride wants to merge 6 commits into
Open
Conversation
DilithiumThoride
added
type: bugfix
Contributor
Author
|
Problem: Turbine UI shows a meaningless "modifier fail" error if it has no rotor. Need to fix that. |
gustovafing
requested changes
Sep 1, 2026
Contributor
Author
|
This was referenced Sep 1, 2026
jurrejelle
requested changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Similar to #5334, the Large Turbine UIs were also never updated to MUI2 and so did not display things like their current rotor speed and power output.
Implementation Details
Needed to add another SyncToClient annotation to RotorHolder. If the RotorHolder's inventory isn't synced, then all attempts to get rotor data fail clientside.
AI Usage
Outcome