Use holders for GT content registration on 1.21 - #5358
Open
gustovafing wants to merge 39 commits into
Open
Conversation
gustovafing
added
1.21.1
ignore changelog
# Conflicts: # src/main/java/com/gregtechceu/gtceu/api/data/worldgen/modifier/DimensionFilter.java # src/main/java/com/gregtechceu/gtceu/api/data/worldgen/modifier/FrequencyModifier.java # src/main/java/com/gregtechceu/gtceu/common/CommonProxy.java # src/main/java/com/gregtechceu/gtceu/common/data/GTFeatures.java # src/main/java/com/gregtechceu/gtceu/common/worldgen/modifier/BiomeDependentPlacement.java # src/main/java/com/gregtechceu/gtceu/common/worldgen/modifier/RubberTreeChancePlacement.java # src/main/java/com/gregtechceu/gtceu/data/loot/ChestGenHooks.java # src/test/java/com/gregtechceu/gtceu/gametest/world/RealWorldItemUsage.java
# Conflicts: # src/main/java/com/gregtechceu/gtceu/api/addon/IGTAddon.java # src/main/java/com/gregtechceu/gtceu/common/CommonProxy.java # src/main/java/com/gregtechceu/gtceu/common/data/GTSoundEntries.java # src/main/java/com/gregtechceu/gtceu/integration/kjs/GregTechKubeJSPlugin.java
github-actions
Bot
added
Tests: Failed
github-actions
Bot
added
Tests: Passed
htmlcsjs
reviewed
Sep 5, 2026
htmlcsjs
left a comment
htmlcsjs
left a comment
Member
There was a problem hiding this comment.
I have read though the code and tested some stuff ingame, admitidly alot of it went over my head but i would appreciate someone else looking through this
| * @apiNote DO NOT REGISTER ANY OF YOUR OWN CONTENT HERE, AS IF YOU DO, IT'LL REGISTER AS IF GTCEu REGISTERED IT | ||
| * AND YOUR DATAGEN AND EVENTS WILL <b><i>NOT</i></b> WORK AS EXPECTED, IF AT ALL. | ||
| */ | ||
| void gtInitComplete(); |
Member
Author
There was a problem hiding this comment.
GT is loaded before addons are, so any addon code will always run after GT initialisation.
| public class GTIngredientTypes { | ||
|
|
||
| public static final DeferredRegister<IngredientType<?>> ITEM_INGREDIENT_TYPES = DeferredRegister | ||
| private static final DeferredRegister<IngredientType<?>> ITEM_INGREDIENT_TYPES = DeferredRegister |
Member
There was a problem hiding this comment.
Why change the visibilities of these
Member
Author
There was a problem hiding this comment.
These should be private since they are only used for registration within this file, other mods shouldn't use these.
| private static final DeferredRegister<IngredientType<?>> ITEM_INGREDIENT_TYPES = DeferredRegister | ||
| .create(NeoForgeRegistries.INGREDIENT_TYPES, GTCEu.MOD_ID); | ||
| public static final DeferredRegister<FluidIngredientType<?>> FLUID_INGREDIENT_TYPES = DeferredRegister | ||
| private static final DeferredRegister<FluidIngredientType<?>> FLUID_INGREDIENT_TYPES = DeferredRegister |
| } | ||
|
|
||
| public static void init() { | ||
| PlaceholderHandler.addPlaceholder(new Placeholder("ae2itemCount") { |
Member
There was a problem hiding this comment.
Does the change from camelCase to snake_case here break preexisting monitors?
Member
Author
There was a problem hiding this comment.
It will, but that's not really a big concern on 1.21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wraps GT content registration in deferred holders, for everything except machines, material system stuff and recipe stuff (they will be handled in seperate PRs each).
No AI