Skip to content

Plungers empty Fluid Pipes #5332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DilithiumThoride wants to merge 2 commits into
base: 1.20.1
Choose a base branch
from
Open

Plungers empty Fluid Pipes #5332

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b2fdaf
Plungers empty Fluid Pipes
DilithiumThoride Aug 22, 2026
3146981
that would be smart
DilithiumThoride Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 33 additions & 4 deletions src/main/java/com/gregtechceu/gtceu/common/blockentity/FluidPipeBlockEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
import com.gregtechceu.gtceu.api.fluids.FluidState;
import com.gregtechceu.gtceu.api.fluids.GTFluid;
import com.gregtechceu.gtceu.api.fluids.attribute.FluidAttribute;
import com.gregtechceu.gtceu.api.item.tool.GTToolType;
import com.gregtechceu.gtceu.api.item.tool.ToolHelper;
import com.gregtechceu.gtceu.api.machine.TickableSubscription;
import com.gregtechceu.gtceu.api.machine.feature.IDataInfoProvider;
import com.gregtechceu.gtceu.api.misc.IOFluidHandlerList;
Expand All @@ -23,10 +25,7 @@
import com.gregtechceu.gtceu.common.item.behavior.PortableScannerBehavior;
import com.gregtechceu.gtceu.common.pipelike.fluidpipe.FluidPipeType;
import com.gregtechceu.gtceu.common.pipelike.fluidpipe.PipeTankList;
import com.gregtechceu.gtceu.utils.EntityDamageUtil;
import com.gregtechceu.gtceu.utils.FormattingUtil;
import com.gregtechceu.gtceu.utils.GTTransferUtils;
import com.gregtechceu.gtceu.utils.GTUtil;
import com.gregtechceu.gtceu.utils.*;

import net.minecraft.ChatFormatting;
import net.minecraft.core.BlockPos;
Expand All @@ -38,6 +37,7 @@
import net.minecraft.sounds.SoundEvents;
import net.minecraft.sounds.SoundSource;
import net.minecraft.util.Mth;
import net.minecraft.world.InteractionResult;
import net.minecraft.world.entity.LivingEntity;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.Blocks;
Expand All @@ -53,6 +53,7 @@
import net.minecraftforge.fluids.FluidStack;
import net.minecraftforge.fluids.capability.IFluidHandler;

import com.mojang.datafixers.util.Pair;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

Expand Down Expand Up @@ -468,6 +469,34 @@ public FluidStack[] getContainedFluids() {
return fluids;
}

@Override
public Pair<@Nullable GTToolType, InteractionResult> onToolClick(ExtendedUseOnContext context) {
var player = context.getPlayer();
if (context.getPlayer() == null) return Pair.of(null, InteractionResult.PASS);
Comment thread
DilithiumThoride marked this conversation as resolved.
Outdated

Pair result = super.onToolClick(context);
if (result.getSecond() != InteractionResult.PASS) return result;

var toolType = context.getToolType();
var stack = context.getItemInHand();

if (toolType.contains(GTToolType.PLUNGER)) {
boolean didEmpty = false;
for (CustomFluidTank pipeTank : getFluidTanks()) {
FluidStack drained = pipeTank.drain(pipeTank.getFluidAmount(), IFluidHandler.FluidAction.SIMULATE);
if (!drained.isEmpty()) {
pipeTank.drain(pipeTank.getFluidAmount(), IFluidHandler.FluidAction.EXECUTE);
didEmpty = true;
}
}
if (didEmpty) {
ToolHelper.onActionDone(player, stack, level, context.getClickLocation());
return Pair.of(GTToolType.PLUNGER, InteractionResult.sidedSuccess(isRemote()));
}
}
return Pair.of(null, InteractionResult.PASS);
}

public static void spawnParticles(Level worldIn, BlockPos pos, Direction direction, ParticleOptions particleType,
int particleCount) {
if (worldIn instanceof ServerLevel serverLevel) {
Expand Down
Loading