Skip to content

Test relocating kotlin-reflect library #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Goooler wants to merge 4 commits into from
Closed

Test relocating kotlin-reflect library #1695

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4424438
Test `relocateKotlinReflectFull`
Goooler Sep 4, 2025
2ce9116
Relocate `kotlin.` to `shadow.kotlin.`
Goooler Sep 17, 2025
5865b62
Exclude `kotlin/kotlin.kotlin_builtins`
Goooler Sep 17, 2025
c39f2c8
Relocate `org.` to `shadow.org.`
Goooler Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/KotlinPluginsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,9 @@ class KotlinPluginsTest : BasePluginTest() {
manifest {
attributes '$mainClassAttributeKey': 'my.MainKt'
}
relocate('kotlin.', 'shadow.kotlin.')
relocate('kotlin.', 'shadow.kotlin.') {
exclude('kotlin/kotlin.kotlin_builtins')
}

@Goooler Goooler Sep 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

OLD: old.jar
NEW: new.jar

 JAR   │ old      │ new      │ diff
───────┼──────────┼──────────┼──────
 class │ 12.6 MiB │ 12.6 MiB │  0 B
 other │ 74.6 KiB │ 74.6 KiB │  0 B
───────┼──────────┼──────────┼──────
 total │ 12.7 MiB │ 12.7 MiB │  0 B

 CLASSES │ old   │ new   │ diff
─────────┼───────┼───────┼───────────
 classes │  3149 │  3149 │ 0 (+0 -0)
 methods │ 27835 │ 27835 │ 0 (+0 -0)
  fields │  6257 │  6257 │ 0 (+0 -0)

=================
====   JAR   ====
=================

 size     │ diff      │ path
──────────┼───────────┼────────────────────────────────────────
          │ -28.7 KiB │ - shadow/kotlin/kotlin.kotlin_builtins
 28.7 KiB │ +28.7 KiB │ + kotlin/kotlin.kotlin_builtins
      0 B │       0 B │ + kotlin/
──────────┼───────────┼────────────────────────────────────────
 28.7 KiB │       0 B │ (total)

Name nameIdentifier18 = Name.identifier("kotlin");
Intrinsics.checkNotNullExpressionValue(nameIdentifier18, "identifier(...)");
BUILT_INS_PACKAGE_NAME = nameIdentifier18;
image

@Goooler Goooler Sep 17, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we should suggest users exclude all builtin files by **/kotlin.kotlin_builtins instead such one.

mergeServiceFiles() // Merge and relocate service files from kotlin-reflect.
}
""".trimIndent(),
Expand Down
Loading