Repository navigation
fix(mcp): describe dynamic outputs with explicit schemas - #1626
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
==========================================
+ Coverage 72.40% 72.75% +0.34%
==========================================
Files 102 102
Lines 15697 15722 +25
==========================================
+ Hits 11366 11438 +72
+ Misses 3100 3044 -56
- Partials 1231 1240 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boolean property schemas inferred from
anymake some MCP clients reject the entiretools/listresponse. Keep the existing Go types and JSON payloads, but provide explicit output schemas forget_task_stats,get_task, andresolve_task.anyOfbranches covering all JSON types, including null. This preserves protocol-specific statistics, restored snapshots, and extension-defined metadata without imposing download-input restrictions on outputs.extrafields, including requests inside resource files, as well asget_task_stats.stats.Validation:
go test ./pkg/mcpserver ./pkg/restpasses, including actual Streamable HTTP calls to the affected tools and REST integration tests.Fixes #1625