Repository navigation
fix: preserve Cookie headers in extension requests - #1581
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1581 +/- ##
==========================================
+ Coverage 70.62% 70.69% +0.06%
==========================================
Files 89 89
Lines 14433 14442 +9
==========================================
+ Hits 10194 10210 +16
+ Misses 3105 3098 -7
Partials 1134 1134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
monkeyWie
added a commit
that referenced
this pull request
Oct 10, 2026
# Conflicts: # ui/flutter/test/widget_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extension fetch and XMLHttpRequest silently dropped Cookie and other headers needed for authenticated downloads after the fetch rewrite. Restore server-side header permissions, including in
no-corsmode, expose response cookies, and combine repeated Cookie values with semicolons. Ignore unsupported transport controls and derive Content-Length from the actual request body. Add regression tests that verify headers received by an HTTP server through both APIs, and exclude browser-only WPT restrictions while retaining syntax and immutability coverage.Stabilize
TestFetcher_InitialIgnoredRangeUsesResponseSize, which could fail when Resolve prefetch completed before Start and no Range request was needed. Flush the Resolve headers and hold its body until the Range request arrives so the test always exercises replacement after an ignored Range request. The downloader implementation is unchanged by this test fix.Validation (Go 1.25.4, matching CI):
go test ./pkg/download/engine/... -count=1passed.go test ./internal/protocol/http -covermode=count -coverprofile=/tmp/gopeed-http-ci-fix-coverage.out -count=1passed.git diff --checkpassed.