Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading to
google/cloud-loggingv2.0.0 introduces breaking changes that will cause the deployment tests to fail. In v2, theEntry::info()method returns an array with snake_case keys (matching the underlying protobuf fields) instead of the camelCase keys used in v1. Specifically, the check forisset($info['textPayload'])infunctions/firebase_remote_config/test/DeployTest.php(line 117) will fail because the key is nowtext_payload. Since these tests are not run by the CI system (as noted in the file header), this breakage might go unnoticed. You should update the test code to use the getter method$log->textPayload(), which is compatible with both versions, or update the array key access totext_payload. Additionally,google/cloud-loggingv2.0.0 requiresgoogle/authversion^1.18; consider updating line 12 to match this requirement.