Skip to content

discoveryengine: add acl_enabled to google_discovery_engine_data_store#18105

Open
JonathanvanWestendorp wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
JonathanvanWestendorp:discoveryengine-datastore-acl-enabled
Open

discoveryengine: add acl_enabled to google_discovery_engine_data_store#18105
JonathanvanWestendorp wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
JonathanvanWestendorp:discoveryengine-datastore-acl-enabled

Conversation

@JonathanvanWestendorp

Copy link
Copy Markdown

Adds the acl_enabled field to google_discovery_engine_data_store.

DataStore.aclEnabled is a create-time, immutable field of the Discovery Engine v1 API, but it is not currently exposed by the provider. Without it, users who need an ACL-enabled data store (so search enforces document-level permissions per end user) must create the data store out-of-band via the REST API / null_resource, outside Terraform state. This adds it as an immutable boolean.

document_processing_config (layout parsing + layout-based chunking) is already supported, so this single field is the remaining gap for provisioning an ACL-enabled, layout-parsed data store entirely in Terraform.

Closes hashicorp/terraform-provider-google#19566

Changes

  • mmv1/products/discoveryengine/DataStore.yaml: new immutable acl_enabled property.
  • New sample/test discoveryengine_datastore_acl_config (GENERIC vertical, CONTENT_REQUIRED, acl_enabled = true).
discoveryengine: added `acl_enabled` field to `google_discovery_engine_data_store` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 26, 2026
@google-cla

google-cla Bot commented Jun 26, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from c2thorn June 26, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add aclEnabled to google_discovery_engine_data_store

2 participants