discoveryengine: add acl_enabled to google_discovery_engine_data_store#18105
Open
JonathanvanWestendorp wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
acl_enabledfield togoogle_discovery_engine_data_store.DataStore.aclEnabledis a create-time, immutable field of the Discovery Engine v1 API, but it is not currently exposed by the provider. Without it, users who need an ACL-enabled data store (so search enforces document-level permissions per end user) must create the data store out-of-band via the REST API /null_resource, outside Terraform state. This adds it as an immutable boolean.document_processing_config(layout parsing + layout-based chunking) is already supported, so this single field is the remaining gap for provisioning an ACL-enabled, layout-parsed data store entirely in Terraform.Closes hashicorp/terraform-provider-google#19566
Changes
mmv1/products/discoveryengine/DataStore.yaml: new immutableacl_enabledproperty.discoveryengine_datastore_acl_config(GENERIC vertical,CONTENT_REQUIRED,acl_enabled = true).