Skip to content

tgc-revival: Fix Compute Instance PMU round-trip serialization in TGC Next#18099

Merged
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
zli82016:fix-tgc-compute-instance-pmu
Jun 26, 2026
Merged

tgc-revival: Fix Compute Instance PMU round-trip serialization in TGC Next#18099
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
zli82016:fix-tgc-compute-instance-pmu

Conversation

@zli82016

@zli82016 zli82016 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Resolves integration test failure TestAccComputeInstance_performanceMonitoringUnit by defaulting empty performance_monitoring_unit to STANDARD during tfplan2cai and safeguarding empty map flattening in cai2hcl.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ff633b7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
terraform-google-conversion View Diff 2 files changed, 10 insertions(+), 2 deletions(-)

@zli82016 zli82016 force-pushed the fix-tgc-compute-instance-pmu branch from ff633b7 to e65d265 Compare June 26, 2026 00:38
@zli82016 zli82016 changed the title Fix Compute Instance PMU round-trip serialization in TGC Next tgc-revival: Fix Compute Instance PMU round-trip serialization in TGC Next Jun 26, 2026
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e65d265:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
terraform-google-conversion View Diff 3 files changed, 10 insertions(+), 3 deletions(-)

@zli82016 zli82016 force-pushed the fix-tgc-compute-instance-pmu branch from e65d265 to 8135b92 Compare June 26, 2026 03:24
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8135b92:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
terraform-google-conversion View Diff 4 files changed, 14 insertions(+), 6 deletions(-)

@zli82016 zli82016 requested a review from c2thorn June 26, 2026 16:45
@zli82016 zli82016 added this pull request to the merge queue Jun 26, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 194c8b5 Jun 26, 2026
30 checks passed
@zli82016 zli82016 deleted the fix-tgc-compute-instance-pmu branch June 26, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants