Skip to content

Add ANY_RESERVATION_THEN_FAIL reservation affinity to container module#18094

Merged
c2thorn merged 2 commits into
GoogleCloudPlatform:mainfrom
pwitkiewicz:any-then-fail-affinity
Jun 26, 2026
Merged

Add ANY_RESERVATION_THEN_FAIL reservation affinity to container module#18094
c2thorn merged 2 commits into
GoogleCloudPlatform:mainfrom
pwitkiewicz:any-then-fail-affinity

Conversation

@pwitkiewicz

@pwitkiewicz pwitkiewicz commented Jun 25, 2026

Copy link
Copy Markdown
Contributor
container: added `ANY_RESERVATION_THEN_FAIL` option to `consume_reservation_type` field in `google_container_cluster` and `google_container_node_pool` resources

Fixes #506977081

@github-actions github-actions Bot requested a review from c2thorn June 25, 2026 20:34
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4e537e9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 7 files changed, 219 insertions(+), 73 deletions(-)
google-beta provider View Diff 7 files changed, 219 insertions(+), 73 deletions(-)
terraform-google-conversion View Diff 2 files changed, 6 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6668 5972 686 10
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerCluster_withNodeConfigReservationAffinityAnyReservationThenFail
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccContainerNodePool_withReservationAffinityAnyReservationThenFail
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccContainerCluster_withNodeConfigReservationAffinityAnyReservationThenFail
✅ Log TestAccContainerNodePool_withReservationAffinityAnyReservationThenFail
✅ Log TestAccProjectIamMemberRemove_memberInMultipleBindings
✅ Log ❌ Error · Log TestAccDataformConfig_update
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@pwitkiewicz, @c2thorn VCR tests complete for 4e537e9!

@pwitkiewicz

Copy link
Copy Markdown
Contributor Author

I am confident that none of the failed tests are related to my change:

  • TestAccDataformConfig_update - issue with the test project, failed to enable some APIs
  • TestAccContainerCluster_regionalWithNodePool - changes to the node pool after tf apply, in ignore_node_count_changes, unrelated to reservation affinity
  • TestAccContainerNodePool_withHostMaintenancePolicy - stockout
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample - failed to delete a subnetwork
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample - failed to create DataStore
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample - requested subnetwork range overlapped with other network
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample - couldn't delete tag value

@modular-magician

modular-magician commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d23fc3e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 7 files changed, 190 insertions(+), 6 deletions(-)
google-beta provider View Diff 7 files changed, 190 insertions(+), 6 deletions(-)
terraform-google-conversion View Diff 2 files changed, 6 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6675 5982 686 7
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@pwitkiewicz, @c2thorn VCR tests complete for d23fc3e!

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed VCR tests are unrelated. go.mod changes look correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants