compute: fix preview=false updates for OrganizationSecurityPolicyRule#18079
compute: fix preview=false updates for OrganizationSecurityPolicyRule#18079sumanth-g31 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@modular-magician reassign-reviewer |
Fixes hashicorp/terraform-provider-google#27885
Summary
This change adds
send_empty_value: trueto thepreviewfield ofOrganizationSecurityPolicyRule.Without this annotation, the generated Terraform provider treats
preview = falseas an empty value and omits it from create and updaterequests. As a result, users cannot reliably update a rule from:
to
because the PATCH request does not include the
previewfield.Root cause
The generated provider code used the condition:
Since
IsEmptyValue()considers the boolean valuefalseto be empty,preview = falsewas filtered out and never added to the request body.Adding
send_empty_value: truecauses Magic Modules to generate:which preserves explicitly configured
falsevalues.Verification
send_empty_value: trueto thepreviewproperty inOrganizationSecurityPolicyRule.yaml.resource_compute_organization_security_policy_rule.gonow includes
previewwhenever it is explicitly configured, includingfalse.SecurityPolicyRuleandRegionSecurityPolicyRule.Background
I initially investigated this issue in hashicorp/terraform-provider-google and opened hashicorp/terraform-provider-google#28000.
As suggested by @melinath in that PR, this fix has been moved to Magic Modules since the provider code is generated from this repository.