Skip to content

added custom flattern#18078

Open
tavasyag wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
tavasyag:datastream_issue
Open

added custom flattern#18078
tavasyag wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
tavasyag:datastream_issue

Conversation

@tavasyag

@tavasyag tavasyag commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Fixes hashicorp/terraform-provider-google#28022

Fixes a perpetual drift on google_datastream_stream where binary_log_position {} in mysql_source_config caused a diff on every plan.
The Datastream API omits binaryLogPosition from GET responses, causing the provider to clear it from state on each refresh.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

datastream: fixed permadiff on `binary_log_position` in `google_datastream_stream`         

@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0e3d7e7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 8 insertions(+), 4 deletions(-)
google-beta provider View Diff 1 file changed, 8 insertions(+), 4 deletions(-)
terraform-google-conversion View Diff 1 file changed, 8 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
20 10 10 0
Affected Service Packages
  • datastream

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@tavasyag VCR tests complete for 0e3d7e7!

@tavasyag

Copy link
Copy Markdown
Contributor Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from SirGitsalot June 25, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_datastream_stream: permadiff on gtid in mysql_source_config

2 participants