Skip to content

feat(config): add per-repo comment overrides for labels config - #96

Merged
vigneshrajsb merged 1 commit into
mainfrom
feat/per-repo-comment-overrides
Feb 9, 2026
Merged

vigneshrajsb merged 1 commit into
mainfrom
feat/per-repo-comment-overrides

Conversation

@vigneshrajsb

@vigneshrajsb vigneshrajsb commented Feb 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Converts defaultControlComments and defaultStatusComments in global_config.labels from flat booleans to { enabled, overrides } objects
  • Adds per-repo override resolution: check overrides[repoFullName] first, fall back to global enabled value
  • Includes DB migration (012) to convert existing boolean values to the new object shape (runs automatically on deploy via k8-start.sh)

Labels Config — Before & After

Before:

{
  "deploy": ["lifecycle-deploy!"],
  "disabled": ["lifecycle-disabled!"],
  "keep": ["lifecycle-keep!"],
  "statusComments": ["lifecycle-status-comments!"],
  "defaultControlComments": true,
  "defaultStatusComments": true
}

After:

{
  "deploy": ["lifecycle-deploy!"],
  "disabled": ["lifecycle-disabled!"],
  "keep": ["lifecycle-keep!"],
  "statusComments": ["lifecycle-status-comments!"],
  "defaultControlComments": {
    "enabled": true,
    "overrides": {}
  },
  "defaultStatusComments": {
    "enabled": true,
    "overrides": {}
  }
}

With per-repo overrides:

{
  "deploy": ["lifecycle-deploy!"],
  "disabled": ["lifecycle-disabled!"],
  "keep": ["lifecycle-keep!"],
  "statusComments": ["lifecycle-status-comments!"],
  "defaultControlComments": {
    "enabled": true,
    "overrides": {
      "org/repo-a": false,
      "org/repo-b": true
    }
  },
  "defaultStatusComments": {
    "enabled": false,
    "overrides": {
      "org/repo-a": true
    }
  }
}

Resolution examples

Scenario enabled overrides Result for org/repo-a
Global on, no override true {} true (inherits global)
Global on, repo disabled true { "org/repo-a": false } false (override wins)
Global off, repo enabled false { "org/repo-a": true } true (override wins)
Global off, no override false {} false (inherits global)

Test plan

  • All 59 utils tests pass including new override scenarios
  • No new TypeScript errors introduced
  • Run pnpm db:migrate / pnpm db:rollback to verify migration up/down
  • Manual verification: query global_config where key = 'labels' and confirm new shape

@vigneshrajsb
vigneshrajsb requested a review from a team as a code owner February 9, 2026 22:15
Convert defaultControlComments and defaultStatusComments from flat
booleans to { enabled, overrides } objects, allowing per-repo
control over mission control and status comments on PRs.
@vigneshrajsb
vigneshrajsb force-pushed the feat/per-repo-comment-overrides branch from 94330dd to fd8f463 Compare February 9, 2026 22:23
@vigneshrajsb
vigneshrajsb merged commit 1ddd8e9 into main Feb 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants