Skip to content

Skip MSBuild-only package files #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BeautyfullCastle wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Skip MSBuild-only package files #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd244a8
Skip MSBuild-only package files
LukeHyunsoo Aug 7, 2026
f160fe6
Skip Unity-incompatible analyzer DLLs
LukeHyunsoo Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/NuGetForUnity.Tests/Assets/Tests/Editor/NuGetTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,26 @@ public void LoadConfigFileTest()
Assert.Pass();
}

[TestCase("buildTransitive/config/analysislevel.globalconfig")]
[TestCase("rulesets/MicrosoftCodeAnalysisReleaseTrackingRulesEnabled.ruleset")]
public void SkipMsBuildOnlyFilesTest(string path)
{
Assert.IsTrue(PackageContentManager.ShouldSkipUnpackingOnPath(path, null));
}

[TestCase("analyzers/roslyn4.3/cs/MessagePack.Analyzers.CodeFixes.dll")]
[TestCase("analyzers/dotnet/cs/Microsoft.CodeAnalysis.Analyzers.dll")]
public void SkipUnityIncompatibleAnalyzerTest(string path)
{
Assert.IsTrue(PackageContentManager.ShouldSkipUnpackingOnPath(path, null));
}

[Test]
public void KeepMessagePackSourceGeneratorTest()
{
Assert.IsFalse(PackageContentManager.ShouldSkipUnpackingOnPath("analyzers/roslyn4.3/cs/MessagePack.SourceGenerator.dll", null));
}

[Test]
[Order(2)]
public void InstallJsonTest([Values] InstallMode installMode)
Expand Down
17 changes: 17 additions & 0 deletions src/NuGetForUnity/Editor/PackageContentManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,23 @@ internal static bool ShouldSkipUnpackingOnPath([NotNull] string path, PackageIns
return true;
}

if (path.StartsWith("buildTransitive/", StringComparison.Ordinal) || path.Contains("/buildTransitive/"))
{
return true;
}

if (path.StartsWith("rulesets/", StringComparison.Ordinal) || path.Contains("/rulesets/"))
{
return true;
}

if ((path.StartsWith("analyzers/", StringComparison.Ordinal) || path.Contains("/analyzers/")) &&
(path.EndsWith(".CodeFixes.dll", StringComparison.Ordinal) ||
Path.GetFileName(path).StartsWith("Microsoft.CodeAnalysis.", StringComparison.Ordinal)))
{
return true;
}

// For now, skip src. We may use it later...
if (path.StartsWith("src/", StringComparison.Ordinal) || path.Contains("/src/"))
{
Expand Down
Loading