Skip to content

Fix login form: use label elements instead of th for accessibility #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VDK wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix login form: use label elements instead of th for accessibility #53

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68d34bd
Fix login form: use label elements instead of th for accessibility
VDK Jun 25, 2026
84c728d
Fix login form: mobile-friendly responsive layout
VDK Aug 30, 2026
97e9ce2
Merge branch 'GerritCodeReview:master' into fix-login-labels
VDK Aug 30, 2026
d6c5360
Minimize responsive login form CSS
VDK Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions resources/com/google/gerrit/httpd/auth/ldap/LoginForm.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<html>
<head>
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>Gerrit Code Review - Sign In</title>
<style type="text/css">
#error_message {
Expand All @@ -12,6 +13,22 @@
#cancel_link {
margin-left: 45px;
}
/* Stack the form in a single column on small screens so it fits
without horizontal scrolling; inputs fill the row width. */
@media (max-width: 600px) {
#login_form table,
#login_form table tbody,
#login_form table tr,
#login_form table td {
display: block;
}
#login_form input[type="text"],
#login_form input[type="password"] {
width: 100%;
box-sizing: border-box;
font-size: 16px; /* avoid iOS auto-zoom on focus */
}
}
</style>
<style id="gerrit_sitecss" type="text/css"></style>
</head>
Expand All @@ -24,14 +41,14 @@ <h1>Sign In to Gerrit Code Review at <span id="hostName">example.com</span></h1>
<form method="POST" action="#" id="login_form" autocomplete="off" onsubmit="return shouldSubmit()">
<table style="border: 0;">
<tr>
<th>Username</th>
<td><label for="f_user">Username</label></td>
<td><input name="username" id="f_user"
type="text"
size="25"
tabindex="1" /></td>
</tr>
<tr>
<th>Password</th>
<td><label for="f_pass">Password</label></td>
<td><input name="password" id="f_pass"
type="password"
size="25"
Expand Down