Skip to content

fix[#1]: none of the feeds vaildate #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GabsEdits merged 6 commits into from
Apr 5, 2026
Merged

fix[#1]: none of the feeds vaildate #3

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff9c9f3
fix[#1]: none of the feeds vaildate
GabsEdits Jun 5, 2025
e85e6a5
fix[#1]: none of the feeds vaildate
GabsEdits Apr 5, 2026
e9567f8
fix: error in date for rss
GabsEdits Apr 5, 2026
8e04c3a
fix: formatting
GabsEdits Apr 5, 2026
78a2b84
cleanup: make date_published optional in JSON
GabsEdits Apr 5, 2026
a68d799
fix: escape XML in generator field in atom.ts
Copilot Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/json.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ export class JsonFeed extends BaseFeed<JsonItem> {
home_page_url: this.options.link,
feed_url: this.options.feed,
icon: this.options.icon,
updated: this.options.updated?.toISOString(),
items: this.items.map((
{ id, title, url, date_published, content_html },
) => ({
id,
title,
url,
date_published: date_published?.toISOString() || new Date().toUTCString,
date_published: date_published?.toISOString() ||
new Date().toUTCString(),
Comment thread
GabsEdits marked this conversation as resolved.
Outdated
...(content_html && { content_html }),
})),
};
Expand Down
1 change: 0 additions & 1 deletion src/rss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export class RssFeed extends BaseFeed<RssItem> {
const emailPart = escapedEmail ? `${escapedEmail} ` : "";
return (
` <webMaster>${emailPart}(${escapedName})</webMaster>\n` +
` <author>${emailPart}(${escapedName})</author>\n` +
` <managingEditor>${emailPart}(${escapedName})</managingEditor>\n`
);
}).join("");
Expand Down
2 changes: 0 additions & 2 deletions test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ Deno.test("RSS Feed Generation", () => {
<language>en-US</language>
<generator>@feed/feed on JSR.io</generator>
<webMaster>test@example.org (John Doe)</webMaster>
<author>test@example.org (John Doe)</author>
<managingEditor>test@example.org (John Doe)</managingEditor>
<item>
<title>First RSS Item</title>
Expand Down Expand Up @@ -157,7 +156,6 @@ Deno.test("JSON Feed Generation", () => {
"title": "JSON Feed Example",
"home_page_url": "http://example.com/json-feed",
"feed_url": "http://example.com/json-feed/feed.json",
"updated": "2024-10-19T15:12:56.000Z",
"items": [
{
"id": "1",
Expand Down