fix item chat links showing English names on dedicated servers - #924
Open
Eldrinn-Elantey wants to merge 4 commits into
Open
fix item chat links showing English names on dedicated servers#924Eldrinn-Elantey wants to merge 4 commits into
Eldrinn-Elantey wants to merge 4 commits into
Conversation
ItemStack.func_151000_E() resolved item names server-side, so on dedicated servers all clients saw English names regardless of locale. Replaced with ChatComponentItemName from GTNHLib which serializes the full ItemStack and lets each client resolve the name in their own locale. Also adds chat hover tooltip for item links and avoids the NBT toString crash from GTNH#21933/#21940.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ItemStack.func_151000_E()resolved item names server-side, so on dedicated servers everyone saw English regardless of locale. Switched to ChatComponentItemName from GTNHLib so each client resolves the name in its own locale, which also avoids the NBT toString crash from GTNewHorizons/GT-New-Horizons-Modpack#21933 and GTNewHorizons/GT-New-Horizons-Modpack#21940. Tested in-game.