Add disable hardware acceleration setting to experimental settings - #9571
Add disable hardware acceleration setting to experimental settings#9571r3dArch wants to merge 1 commit into
Conversation
|
Just wondering, why did you choose to place this in the Experimental Settings? |
|
It's mostly just because that is where the Replace HTTP Cache setting is, which I based most of my code on. Although it is something that most users probably shouldn't use since it will hurt performance. Looking through the settings headers, I think the only other spot that makes sense would be "General". Do you have somewhere else you'd prefer this setting to be? |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
I tested in dev too and was able to confirm that the GPU is not used with PikachuEXE code + linux processus manager showing no GPU usage for electron when hardware acceleration is disabled in FreeTube settings. |


Pull Request Type
Related issue
closes #2296
Description
This PR adds a "Disable Hardware Acceleration" setting to the experimental settings section of the settings page.
Screenshots
Before
After
Testing
I tested that the disable hardware acceleration is actually working using the
electron.app.isHardwareAccelerationEnabled()function which I temporarily added to main/index.js, but I couldn't find a way to determine if it is working using the electron JS console.Desktop
Additional context
I based a lot of this code on the implementation of the Replace HTTP Cache setting.