Fix some accessibility issues#347
Open
andershol wants to merge 1 commit into
Open
Conversation
Member
|
In this PR , the paceholder section is being removed from the blog page. However, this is not mentioned in the statement. |
Contributor
Author
The placeholders have not been removed. If you look a bit closer you see that the 10 sections have been replaced by a simple loop to produce the exact same content to make it a bit more maintainable (it felt silly to do the header replacement 10 times). |
Member
|
Doesn't this conflict with your changes in #345? |
Contributor
Author
|
Sure, in the sense that both touch the same neighborhood of code, so I will need to fix some conflicts should one be merged, otherwise they complement each other. Not sure what you were trying to say. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #212
Fixes the language selector and the header level continuity. The header change only seem to move the layout a small amount on the side headers in thankyou.php, sponsor.php.