Add transaction-scoped local variable storage - #4570
Draft
arnaud-lacurie wants to merge 2 commits into
Draft
Conversation
Adds Transaction.setLocalVariable/getLocalVariables, backed by RecordContextTransaction's FDBRecordContext session (the same mechanism already used for BoundSchemaTemplate), so values live only as long as the transaction does. No SQL surface yet — that's the next PRs in the stack. All existing implementers of Transaction (RecordStoreAnd- RecordContextTransaction, and the test-only InMemoryTransactionManager) are updated to satisfy the two new interface methods.
Drop restating-the-obvious @PARAM lines and a reference to the PR stack structure that doesn't belong in code comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bottom of a stack splitting PR #4198 into reviewable pieces. Adds
Transaction.setLocalVariable/getLocalVariables, backed by the same FDB session-map mechanism already used forBoundSchemaTemplate. No SQL surface yet -- that's added in the next PR.