Add SET TRANSACTION VARIABLE statement - #4564
Draft
arnaud-lacurie wants to merge 2 commits into
Draft
Conversation
Adds grammar for SET TRANSACTION VARIABLE name = constant, replacing the unimplemented MySQL-fork SET/variableClause dead grammar it displaces. Dispatches through a new SetLocalVariableConstantAction (available in every MetadataOperationsFactory, not just the ones backed by a real catalog, since it only touches the transaction's session layer) down to the storage added in the previous PR. Tagged IS_DDL_STATEMENT so the plan cache is bypassed, since the literal value is baked directly into the ConstantAction. There's no SQL-level way to read a variable back yet -- that's GET_VARIABLE, in the next stacked PR -- so this PR's tests assert directly on Transaction.getLocalVariables().
Drop a reference to the PR stack structure that doesn't belong in code comments.
arnaud-lacurie
force-pushed
the
apple/arnaud-lacurie/local-vars/2-set
branch
from
September 5, 2026 17:50
ba17541 to
03120e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds grammar for SET TRANSACTION VARIABLE name = constant, replacing
the unimplemented MySQL-fork SET/variableClause dead grammar it
displaces. Dispatches through a new SetLocalVariableConstantAction
(available in every MetadataOperationsFactory, not just the ones
backed by a real catalog, since it only touches the transaction's
session layer) down to the storage added in the previous PR. Tagged
IS_DDL_STATEMENT so the plan cache is bypassed, since the literal
value is baked directly into the ConstantAction.
There's no SQL-level way to read a variable back yet -- that's
GET_VARIABLE, in the next stacked PR -- so this PR's tests assert
directly on Transaction.getLocalVariables().
Stack created with GitHub Stacks CLI • Give Feedback 💬