Skip to content

Read release app ID from secrets - #51

Closed
tomusdrw wants to merge 1 commit into
mainfrom
c/fix-release-app-id
Closed

Read release app ID from secrets#51
tomusdrw wants to merge 1 commit into
mainfrom
c/fix-release-app-id

Conversation

@tomusdrw

@tomusdrw tomusdrw commented Jun 7, 2026

Copy link
Copy Markdown
Member

Summary

  • read PR_APP_ID from repository secrets instead of repository variables
  • fixes [@octokit/auth-app] appId option is required in the Prepare release workflow

Validation

  • actionlint .github/workflows/*.yml
  • git diff --check

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 69c55bcf-80b5-4f5e-925b-1df34d81497e

📥 Commits

Reviewing files that changed from the base of the PR and between f8625b6 and cded3ec.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

Single line change in release workflow: GitHub App ID source changes from GitHub Variables to GitHub Secrets for token creation in the release version bump process.

Changes

Release Workflow Configuration

Layer / File(s) Summary
GitHub App ID source migration
.github/workflows/release.yml
The app-id input for GitHub App token creation is changed to fetch from GitHub Secrets instead of GitHub Variables.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • FluffyLabs/typeberry-native#50: Updates release workflow to use secrets.PR_APP_ID instead of vars.PR_APP_ID for GitHub App token creation in version-bump PR.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: switching from reading the app ID from variables to secrets in the release workflow.
Description check ✅ Passed The description clearly explains the change (reading PR_APP_ID from secrets instead of variables) and the issue it fixes (appId option required error).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch c/fix-release-app-id

Comment @coderabbitai help to get the list of available commands and usage tips.

@tomusdrw tomusdrw closed this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant