[codex] Refresh security dependency locks#1249
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesDependency Refresh
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alfred-openspec
left a comment
There was a problem hiding this comment.
Approved. CI is green except the Nix flake validation, which is failing because the pnpm dependency store hash is stale after the lockfile refresh.
alfred-openspec
left a comment
There was a problem hiding this comment.
Re-approved after the latest updates.
Summary
This replaces the two bot dependency PRs with a cleaner direct-update path:
tmpdrops out of the dependency tree entirelypicomatchmicromatch -> picomatchlockfile edge to patchedpicomatch@2.3.2without forcing apicomatchmajor override undermicromatchWhy
The reported
picomatchandtmpadvisories are real, but the bot PRs patch subdependencies in a brittle way. In particular, pinningtmp@0.2.6is already stale because a follow-uptmpadvisory is patched in0.2.7; removingtmpfrom the tree is better.fast-glob@3.3.3andmicromatch@4.0.8are already current, andmicromatchstill depends onpicomatch:^2.3.1, so the productionpicomatchfix is a lock refresh to2.3.2rather than forcing v4.Validation
pnpm install --frozen-lockfilepnpm run lint(passes; one unrelated existing warning insrc/core/references.ts)pnpm test(98 files, 1787 tests passed)pnpm why tmpreturns no dependency pathpnpm auditreports notmporpicomatchadvisories remainingSummary by CodeRabbit