Skip to content

chore(clang): upgrade to clang 22#2679

Open
coleaeason wants to merge 2 commits into
mainfrom
cole/clang22
Open

chore(clang): upgrade to clang 22#2679
coleaeason wants to merge 2 commits into
mainfrom
cole/clang22

Conversation

@coleaeason

Copy link
Copy Markdown
Contributor

Details

As with the other PRs, this upgrades this repo to clang 22. The only functional change in this repo is the switch from atomic_store and atomic_load to atomic with .load(), the previous pattern was deprecated in c++-20, but not marked deprecated until we upgraded from libstdc++-13-dev to libstdc++-16-dev

Fixed Issues

Related https://github.com/Expensify/Expensify/issues/659917

Tests


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@coleaeason coleaeason self-assigned this Jul 15, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9d5e34203a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +168 to +169
- name: Download binaries
uses: ./.github/actions/composite/download-binaries

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the checkout before using the local action

On tag/release runs this job now starts with uses: ./.github/actions/composite/download-binaries, but the preceding checkout was removed and each GitHub Actions job gets a fresh workspace. Without checking out the repository first, the runner cannot resolve the local composite action path, so the release upload job fails before restoring, stripping, or uploading the Bedrock binary.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants