[No QA] [Hold for production deploy] Docs updates for E/A#96181 rename Magic code to Security code - #96793
Conversation
Co-authored-by: Nikki Wines <NikkiWines@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Nikki Wines <NikkiWines@users.noreply.github.com>
|
Fixed the failing Root cause: cspell reported one unknown word — Fix: Reworded to match the section heading right above it (which already says "…I didn't request"):
This drops |
|
@MelvinBot please also review the help docs for the phrase "magic link" and replace it with "security link" |
|
I reviewed the help docs ( What I checked
If you were thinking of a specific article that uses "magic link" (or meant a different phrase), point me at it and I'll update it. |
HelpDot Documentation ReviewOverall AssessmentThis PR is a terminology migration that replaces "Magic Code" / "magic code" with "security code" across 11 New Expensify help articles (settings, domains, and Expensify Card). The changes are limited to wording in body text, headings, YAML metadata ( Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
Approved, but holding til #96181 hits prod |
|
On prod now! |
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.4.45-0 🚀
|
Explanation of Change
Follow-up help-site updates for #96181, which renamed every user-facing "Magic code" reference to "Security code" across NewDot.
This PR updates the New Expensify (
docs/articles/new-expensify/) help articles so the documentation matches the current UI terminology. Only NewDot articles were changed — Expensify Classic articles still say "Magic Code" because that product's copy was not changed by the source PR.Files updated (10)
new-expensify/settings/Avoiding-common-scams.mdnew-expensify/settings/Login-Troubleshooting.mdnew-expensify/settings/Update-Email-Address.mdnew-expensify/settings/Account-Settings.mdnew-expensify/settings/Two-Factor-Authentication.mdnew-expensify/settings/Merge-Accounts.mdnew-expensify/domains/Claim-and-Verify-a-Domain.mdnew-expensify/expensify-card/Update-Your-Expensify-Card-Mailing-Address.mdnew-expensify/expensify-card/Cardholder-Settings-and-Features.mdnew-expensify/expensify-card/Approve-UK-EU-Expensify-Card-Transactions-Using-3DS-Authentication.mdTerminology & casing
Matched the live NewDot UI casing (from
src/languages/en.ts): sentence case security code in prose, capitalized Security code only as a label/heading/sentence start. Button references were updated to the exact new UI labels — e.g. Didn't receive a security code? and Use security code.The source PR only changed NewDot frontend copy (
src/languages/*.ts); it did not change backend-generated email templates. A couple of doc references describe the login-code email itself rather than in-app UI:Login-Troubleshooting.md→ "Search for Expensify security code…" (the email subject/sender you search your inbox for)I updated these for consistency, but please confirm the actual login-code email subject line now says "security code" before merging. If the email still says "Magic Code", that one line should be reverted to match what users actually receive.
Guidelines applied
Reviewed and applied
docs/HELP_AUTHORING_GUIDELINES.md,docs/HELPSITE_NAMING_CONVENTIONS.md, anddocs/TEMPLATE.md. No structural/heading changes were made — this is a terminology-only update.@NikkiWines, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.