Skip to content

[No QA] [Hold for production deploy] Docs updates for E/A#96181 rename Magic code to Security code - #96793

Merged
NikkiWines merged 2 commits into
mainfrom
claude-securityCodeDocsUpdate
Jul 24, 2026
Merged

[No QA] [Hold for production deploy] Docs updates for E/A#96181 rename Magic code to Security code#96793
NikkiWines merged 2 commits into
mainfrom
claude-securityCodeDocsUpdate

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Follow-up help-site updates for #96181, which renamed every user-facing "Magic code" reference to "Security code" across NewDot.

This PR updates the New Expensify (docs/articles/new-expensify/) help articles so the documentation matches the current UI terminology. Only NewDot articles were changed — Expensify Classic articles still say "Magic Code" because that product's copy was not changed by the source PR.

Files updated (10)

  • new-expensify/settings/Avoiding-common-scams.md
  • new-expensify/settings/Login-Troubleshooting.md
  • new-expensify/settings/Update-Email-Address.md
  • new-expensify/settings/Account-Settings.md
  • new-expensify/settings/Two-Factor-Authentication.md
  • new-expensify/settings/Merge-Accounts.md
  • new-expensify/domains/Claim-and-Verify-a-Domain.md
  • new-expensify/expensify-card/Update-Your-Expensify-Card-Mailing-Address.md
  • new-expensify/expensify-card/Cardholder-Settings-and-Features.md
  • new-expensify/expensify-card/Approve-UK-EU-Expensify-Card-Transactions-Using-3DS-Authentication.md

Terminology & casing

Matched the live NewDot UI casing (from src/languages/en.ts): sentence case security code in prose, capitalized Security code only as a label/heading/sentence start. Button references were updated to the exact new UI labels — e.g. Didn't receive a security code? and Use security code.

⚠️ Please verify — items dependent on backend, not this frontend-only PR

The source PR only changed NewDot frontend copy (src/languages/*.ts); it did not change backend-generated email templates. A couple of doc references describe the login-code email itself rather than in-app UI:

  • Login-Troubleshooting.md → "Search for Expensify security code…" (the email subject/sender you search your inbox for)

I updated these for consistency, but please confirm the actual login-code email subject line now says "security code" before merging. If the email still says "Magic Code", that one line should be reverted to match what users actually receive.

Guidelines applied

Reviewed and applied docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md. No structural/heading changes were made — this is a terminology-only update.


@NikkiWines, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Nikki Wines <NikkiWines@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 22, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#96181 rename Magic code to Security code [No QA] Docs updates for E/A#96181 rename Magic code to Security code Jul 22, 2026
@OSBotify

This comment has been minimized.

Co-authored-by: Nikki Wines <NikkiWines@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Fixed the failing spellcheck check. ✅

Root cause: cspell reported one unknown word — unrequested — at Avoiding-common-scams.md:108 (Issues found: 1 in 1 file). The word was actually pre-existing on main ("Receiving an unrequested Magic Code…"), but the spell-changed job only scans files touched by a PR, so it never got flagged until this PR modified that file.

Fix: Reworded to match the section heading right above it (which already says "…I didn't request"):

No. Receiving a security code you didn't request does not mean your account is compromised.

This drops unrequested (no uncommon words introduced), so cspell now passes. All other checks were already green.

@NikkiWines

Copy link
Copy Markdown
Contributor

@MelvinBot please also review the help docs for the phrase "magic link" and replace it with "security link"

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I reviewed the help docs (docs/articles/ + docs/Hidden/) and there's no occurrence of "magic link" anywhere in them — so there's nothing to replace. No changes pushed.

What I checked
  • Ran a case-insensitive search for magic[ -]?link across all of App/docs0 matches.
  • The only "magic link" strings in the App repo are in frontend code (internal identifiers, code comments, and test names for the auto-authentication flow, e.g. src/types/onyx/Session.ts, src/pages/ValidateLoginPage/) — none are user-facing help content, so they're out of scope for a docs terminology change.
  • The docs do still contain "Magic Code" references, but those are all in Expensify Classic articles (e.g. docs/articles/expensify-classic/settings/Avoiding-common-scams.md, Email-Notifications.md), which this PR intentionally leaves unchanged since Classic's copy wasn't updated by Replace user-facing "Magic code" copy with "Security code" #96181. "Magic Code" is also a different term from "magic link".

If you were thinking of a specific article that uses "magic link" (or meant a different phrase), point me at it and I'll update it.

@NikkiWines
NikkiWines marked this pull request as ready for review July 23, 2026 11:04
Comment thread docs/articles/new-expensify/settings/Login-Troubleshooting.md
Comment thread docs/articles/new-expensify/settings/Login-Troubleshooting.md
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR is a terminology migration that replaces "Magic Code" / "magic code" with "security code" across 11 New Expensify help articles (settings, domains, and Expensify Card). The changes are limited to wording in body text, headings, YAML metadata (description, keywords, internalScope), FAQ entries, and one button/option reference. No structural, heading-hierarchy, or workflow changes are introduced. The migration is applied consistently and cleanly within each modified article.

Scores Summary

  • Readability: 9/10 - Sentences remain clear and well-formed after the swap; step formatting and flow are untouched. Parentheticals like "security code (your login code)" preserve clarity.
  • AI Readiness: 8/10 - keywords, description, and internalScope were updated in lockstep with body text, keeping metadata aligned with new search intent. Task-based headings and single-# hierarchy are preserved. Minor risk: dropping "Magic Code" entirely from keywords may lose retrieval for users who still search the legacy term.
  • Style Compliance: 7/10 - Terminology is applied uniformly. Main risk is UI accuracy per HELPSITE_NAMING_CONVENTIONS.md: bolded/quoted references must match the exact product UI text.

Key Findings

  • Consistency (positive): Within every changed hunk, the swap is thorough - body copy, headings, FAQ questions/answers, and all three metadata fields were updated together. No half-migrated sentences appear in the diff.
  • Casing normalization (positive): The proper-noun "Magic Code" is now lowercase "security code," reading as a generic descriptor rather than a branded feature - appropriate if the product no longer brands it.
  • UI-exact button/option reference (must verify): In Login-Troubleshooting.md, the SSO prompt is rewritten to "Would you like to sign in with a security code or Single Sign-On?" and the choice changes from Magic Code to Use security code. Per the Core UI Referencing and Button Naming rules, these must match the live UI string exactly (both the prompt sentence and the button label). Please confirm the product actually shows "Use security code."
  • Keyword coverage (minor): Login-Troubleshooting.md and Avoiding-common-scams.md removed "Magic Code" from keywords entirely. If some users still search "magic code," consider retaining it as a secondary keyword during the transition.

Recommendations

  • Confirm every bolded/quoted UI reference matches the actual in-product text, especially the SSO option sentence and the Use security code button in Login-Troubleshooting.md.
  • Consider keeping "magic code" as a fallback keyword in the affected articles' keywords for a transition period to protect search retrieval.
  • Verify this terminology change is coordinated with the product UI so docs and app stay in sync (naming conventions require docs to match the shipped UI).

Files Reviewed

  • docs/articles/new-expensify/domains/Claim-and-Verify-a-Domain.md - body text swap, clean.
  • docs/articles/new-expensify/expensify-card/Approve-UK-EU-Expensify-Card-Transactions-Using-3DS-Authentication.md - step wording swap, clean.
  • docs/articles/new-expensify/expensify-card/Cardholder-Settings-and-Features.md - body text swap, clean.
  • docs/articles/new-expensify/expensify-card/Update-Your-Expensify-Card-Mailing-Address.md - step wording swap, clean.
  • docs/articles/new-expensify/settings/Account-Settings.md - keywords + steps swap, clean.
  • docs/articles/new-expensify/settings/Avoiding-common-scams.md - full metadata + headings + body + FAQ swap, thorough; consider keyword fallback.
  • docs/articles/new-expensify/settings/Login-Troubleshooting.md - metadata + headings + body swap; verify SSO prompt and Use security code button match UI.
  • docs/articles/new-expensify/settings/Merge-Accounts.md - step wording swap, clean.
  • docs/articles/new-expensify/settings/Two-Factor-Authentication.md - body text swap, clean.
  • docs/articles/new-expensify/settings/Update-Email-Address.md - metadata + body + FAQ swap, clean.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott stephanieelliott changed the title [No QA] Docs updates for E/A#96181 rename Magic code to Security code [No QA] [Hold for production deploy] Docs updates for E/A#96181 rename Magic code to Security code Jul 23, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

Approved, but holding til #96181 hits prod

@NikkiWines

Copy link
Copy Markdown
Contributor

On prod now!

@NikkiWines
NikkiWines merged commit 4b47658 into main Jul 24, 2026
19 checks passed
@NikkiWines
NikkiWines deleted the claude-securityCodeDocsUpdate branch July 24, 2026 10:12
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.4.45-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants