[No QA] Revert #96228#96661
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8f29f96fd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| > | ||
| <ScreenWrapper | ||
| shouldEnableKeyboardAvoidingView | ||
| shouldEnableKeyboardAvoidingView={isNewManualExpenseFlowEnabled} |
There was a problem hiding this comment.
When NEW_MANUAL_EXPENSE_FLOW is off, this page renders IOURequestStepAmountWithTransactionOnly for the manual tab, and that amount step is embedded without its own ScreenWrapper in the create flow. Tying the parent ScreenWrapper's keyboard avoiding view to the beta therefore disables keyboard avoidance for the legacy amount form; on mobile/touch devices the keyboard can cover the amount input or submit controls. Keep keyboard avoidance enabled for the non-beta manual amount flow as well.
Useful? React with 👍 / 👎.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Merged as its a straight revert of a PR that had many deploy blockers. Asking for CP. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.41-2 🚀
|
Help site review — no docs changes requiredI reviewed the changes in this PR against the help site articles under Why no docs update is needed: This PR is a straight revert of #96228 ("feat: remove isNewManualExpenseFlowEnabled beta flag"). It re-introduces the
For the general (non-beta) audience this restores the prior behavior that shipped before #96228, so it does not introduce any new user-facing behavior that the help site would need to describe. Beta-gated flows are not documented on the public help site, and the existing help articles already reflect the pre-#96228 (restored) behavior — no article edits are needed. @thelullabyy, since this is a revert that restores previously-documented behavior, there's nothing to update on the help site. If you believe a specific help article no longer matches current behavior, let me know which one and I'll take another look. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.41-4 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.42-0 🚀
|
|
🤖 Help site review — no changes required I reviewed the changes in this PR against the help site articles under Why: This is Since the new inline flow is not generally available and the default behavior reverts to what the help site already describes, there is nothing new to document and nothing existing that becomes inaccurate. I also searched the articles for the affected UI strings/flow ("create expense with amount", "manual expense flow", inline amount editing) and found no article that documents the reverted behavior. If/when the new manual expense flow ships to all users (beta removed), that would be the point to add or update help site coverage. @thelullabyy, no linked help site PR was created since no docs changes are required. Please confirm this assessment matches the intended behavior — if you believe a help article does need updating, let me know which article/flow and I'll create the draft PR. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.42-1 🚀
Bundle Size Analysis (Sentry): |
4 participants
Explanation of Change
Fixed Issues
$ #93854
$ #96593
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
evidences.mov