-
Notifications
You must be signed in to change notification settings - Fork 4k
[No QA] Upgrade Node to 26.5.0 and npm to 11.17.0 #96205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5e4b1bc
4bd9c99
04133c8
def38bb
0325fe7
590561d
92ed461
3160ab4
57beacd
3bc0230
231149c
c380661
2722679
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,10 @@ jobs: | |
| lint: | ||
| name: ESLint check | ||
| if: ${{ github.event.head_commit.author.name != 'OSBotify' || github.event_name == 'push' }} | ||
| runs-on: blacksmith-4vcpu-ubuntu-2404 | ||
| # A cold-cache run lints the whole repo with type-aware rules, which loads the full TypeScript | ||
| # program in every worker (~12GB of heap each, regardless of how files are split between workers). | ||
| # 2 workers with a 14GB heap cap need ~30GB of memory, so this requires the 32GB (8vcpu) runner. | ||
| runs-on: blacksmith-8vcpu-ubuntu-2404 | ||
| steps: | ||
| - name: Checkout | ||
| uses: useblacksmith/checkout@1c9394c220d293645707b625ba9d79685f093a8f # v1 | ||
|
|
@@ -48,6 +51,11 @@ jobs: | |
| # If lint fails, we clear the cache and retry to rule out false positives. | ||
| # See: https://typescript-eslint.io/troubleshooting/faqs/eslint/#can-i-use-eslints---cache-with-typescript-eslint | ||
| - name: Lint JavaScript and Typescript with ESLint | ||
| env: | ||
| # See the runs-on comment: each worker needs ~12GB of heap on a cold cache, so run | ||
| # 2 workers with a 14GB cap instead of ESLint's defaults (4 workers, 8GB cap). | ||
| ESLINT_CONCURRENCY: 2 | ||
| NODE_OPTIONS: --max_old_space_size=14336 | ||
|
Comment on lines
+54
to
+58
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This might be a temporal fix as right now ESLint's result cache hashes We might be able to reverse this part when we start to cache under the new nodeVersion |
||
| run: | | ||
| if ! npm run lint; then | ||
| echo "Lint failed, clearing cache and retrying..." | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 20.20.2 | ||
| 26.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add
ESLINT_CONCURRENCY: 2? The lint script currently uses--concurrency=auto