[Part 13] Remove Onyx.connect from LocalePhoneNumber

[marufsharifi]

Explanation of Change

This PR threads the active formatPhoneNumber function from useLocalize() through the IOU split, split distance, split scan, complete split, and duplicate expense/report flows.

The main behavior change is that Split.ts no longer owns/imports its own phone formatter for optimistic participant personal details. Instead, callers pass the current locale-aware formatter into:

• splitBill
• splitBillAndOpenReport
• startSplitBill
• completeSplitBill
• createSplitsAndOnyxData
• createDistanceRequest
• duplicateExpenseTransaction
• duplicateReport
• bulkDuplicateExpenses
• bulkDuplicateReports

The added callers cover manual split submit, scan skip-confirmation split submit, distance manual/GPS/odometer submit, completing split details, single duplicate actions, and bulk duplicate actions from Search.

Fixed Issues

$ #66327
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Case 1: Manual Split From Existing Chat Or Room

1. Open an existing 1:1 chat, group chat, or room.
2. Use the composer +.
3. Choose Split expense.
4. Choose Manual.
5. Enter an amount.
6. View participants, including a phone-number participant if available.
7. Submit.
8. Verify it does not create a new workspace expense report.
9. Verify the phone-number participant display is formatted correctly.

Case 2: Complete Split Details After Scan

1. Create a split scan expense that requires details to be completed.
2. Open the split expense details page.
3. Fill in any missing required fields.
4. Confirm/complete the split.
5. Verify participant display names, including phone-number participants, remain formatted correctly.

Case 3: Distance Split From Existing Chat Or Room

1. Open an existing chat, group chat, or room.
2. Use composer +.
3. Choose Split expense.
4. Choose Distance.
5. Add route/manual distance details.
6. Submit.
7. Verify the phone-number participant display is formatted correctly.

Case 4: Duplicate Single Expense From Expense Details

1. Open an existing expense in a workspace expense report.
2. Open the expense details/options menu.
3. Choose Duplicate expense.
4. Verify the duplicated expense is created in the selected/default workspace expense report.
5. If duplicating a distance expense, verify the duplicate keeps distance details.

Case 5: Duplicate Full Report

1. Open a workspace expense report with multiple expenses.
2. Open the report options menu.
3. Choose Duplicate report.
4. Verify a copied expense report is created in the target workspace.
5. Verify eligible expenses are copied.
6. Verify distance expenses are handled correctly when the target workspace supports them.

Case 6: Bulk Duplicate Reports From Search

1. Go to Search.
2. Select multiple reports.
3. Choose the bulk duplicate reports action.
4. Verify each duplicated report is created in the correct workspace when the source workspace is accessible.
5. Verify reports fall back to the default workspace when needed.
6. Verify eligible report expenses are copied.

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Case 1: Manual Split From Existing Chat Or Room

Screencast.From.2026-07-17.20-00-34.webm

Case 2: Complete Split Details After Scan

Screencast.From.2026-07-17.20-05-08.webm

Case 3: Distance Split From Existing Chat Or Room

Screencast.From.2026-07-17.20-06-02.webm

Case 4: Duplicate Single Expense From Expense Details

Screencast.From.2026-07-17.20-12-02.webm

Case 5: Duplicate Full Report

Screencast.From.2026-07-17.20-15-02.webm

Case 6: Bulk Duplicate Reports From Search

Screencast.From.2026-07-17.20-16-18.webm

[melvin-bot]

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useBulkDuplicateAction.ts	100.00% <100.00%> (ø)
src/hooks/useBulkDuplicateReportAction.ts	100.00% <100.00%> (ø)
src/libs/actions/IOU/Duplicate.ts	91.64% <ø> (ø)
src/libs/actions/IOU/Split.ts	72.24% <ø> (ø)
...stance/handleMoneyRequestStepDistanceNavigation.ts	82.79% <ø> (ø)
...RequestStepDistance/hooks/useDistanceNavigation.ts	90.00% <100.00%> (+0.52%)	⬆️
...RequestStepDistance/hooks/useOdometerNavigation.ts	100.00% <100.00%> (ø)
...equestStepScan/components/ScanSkipConfirmation.tsx	77.57% <100.00%> (ø)
.../request/step/confirmation/useExpenseSubmission.ts	72.30% <ø> (+0.30%)	⬆️
.../components/MoneyRequestHeaderSecondaryActions.tsx	0.50% <0.00%> (ø)
... and 4 more
... and 247 files with indirect coverage changes

[shubham1206agra]

@marufsharifi Bump here

[marufsharifi]

@shubham1206agra, sorry for the delay. I will finalize this asap. thanks.

[trjExpensify]

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

[shubham1206agra]

@marufsharifi Bump here again

[marufsharifi]

@shubham1206agra Sorry for the delay.

This PR is ready for another review. All requested feedback has been addressed, and the required actions/checks are passing. Please take another look when you get a chance.

[marufsharifi]

Hi @shubham1206agra, apologies for the delay. I wasn't feeling well yesterday. I've now addressed the feedback, updated the PR, and it's ready for another review. Whenever you have a chance, could you please take another look? Thank you!