fix: treat envelope-shaped non-2xx as failure even when status is 0 - #8
Open
AshSgDe29071999 wants to merge 1 commit into
Open
fix: treat envelope-shaped non-2xx as failure even when status is 0#8AshSgDe29071999 wants to merge 1 commit into
AshSgDe29071999 wants to merge 1 commit into
Conversation
json.Unmarshal zeroes a missing status field, so a 500 whose body looks like the success envelope used to return err == nil and advance callers. Closes EverMind-AI#6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
(*httpClient).dotreated any JSON body that unmarshaled as the backend envelope withstatus == 0as success, without checkingresp.StatusCode.json.Unmarshalzeroes a missing field, so a 500 whose body is envelope-shaped but has no explicit status returnederr == nil.Fixes #6.
Change
If envelope
statusis 0, also require HTTP 2xx. Non-2xx goes through the same auth / upstream classification as a non-JSON error body.Test