Skip to content

fix: dispose CodeQL-flagged locals, correct the blob projector README #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeyzimarev merged 3 commits into from
Aug 21, 2026
Merged

fix: dispose CodeQL-flagged locals, correct the blob projector README #578

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d250ec
fix: dispose locals flagged by CodeQL cs/local-not-disposed
alexeyzimarev Aug 21, 2026
bd6b98e
Merge branch 'dev' into fix/codeql-local-not-disposed
alexeyzimarev Aug 21, 2026
16e8343
docs: fix the blob projector README custom naming example
alexeyzimarev Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Azure/test/Eventuous.Tests.Azure.Storage.Blobs/BlobStorageProjectorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ BlobContainerClient GetContainer(string containerName) =>
async Task SetupExistingBlob<TState>(string containerName, string blobName, TState initialState) {
var blobClient = GetContainer(containerName).GetBlobClient(blobName);
var json = JsonSerializer.SerializeToUtf8Bytes(initialState);
await blobClient.UploadAsync(new MemoryStream(json), overwrite: true);
using var stream = new MemoryStream(json);
await blobClient.UploadAsync(stream, overwrite: true);
Comment on lines +40 to +41

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. uploadasync awaits missing nocontext() 📘 Rule violation ☼ Reliability

The newly modified await blobClient.UploadAsync(...) calls don't use .NoContext(), which breaks
the repo convention for avoiding captured synchronization context on I/O awaits. This can increase
deadlock risk and reduce scalability in async flows.
Agent Prompt 
## Issue description
The modified `UploadAsync` awaits do not use `.NoContext()`.

## Issue Context
Compliance requires async I/O awaits to use `.NoContext()` (`ConfigureAwait(false)`) per repository convention.

## Fix Focus Areas
- src/Azure/test/Eventuous.Tests.Azure.Storage.Blobs/BlobStorageProjectorTests.cs[37-42]
- src/Azure/test/Eventuous.Tests.Azure.Storage.Blobs/BlobStorageProjectorTests.cs[71-77]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

}

/// <summary>
Expand Down Expand Up @@ -71,7 +72,8 @@ Func<Task> OverwriteBlob(string containerName, string blobName) => async () => {
var modifiedState = new ConcurrentState { Value = 999 };
var modifiedJson = JsonSerializer.SerializeToUtf8Bytes(modifiedState);
var blobClient = GetContainer(containerName).GetBlobClient(blobName);
await blobClient.UploadAsync(new MemoryStream(modifiedJson), overwrite: true);
using var stream = new MemoryStream(modifiedJson);
await blobClient.UploadAsync(stream, overwrite: true);
};

// ========== SYNC STATE HANDLER TESTS ==========
Expand Down
8 changes: 5 additions & 3 deletions src/Experimental/src/Eventuous.ElasticSearch/Store/ElasticSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ public class ElasticSerializer(IElasticsearchSerializer builtIn, JsonSerializerO
readonly ITypeMapper _typeMapper = typeMapper ?? TypeMap.Instance;

public object Deserialize(Type type, Stream stream) {
var reader = new BinaryReader(stream);
var obj = JsonSerializer.Deserialize(reader.ReadBytes((int)stream.Length), type, _options);
// Read the stream directly: a BinaryReader here would either close the caller's stream when
// disposed, or leak its buffers when not, and it only added a full copy of the payload
var obj = JsonSerializer.Deserialize(stream, type, _options);
Comment on lines +14 to +16

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

2. elasticserializer does sync stream i/o 📘 Rule violation ➹ Performance

ElasticSerializer.Deserialize and Serialize perform synchronous read/write operations against
Stream using JsonSerializer.Deserialize(...) and Utf8JsonWriter, despite async alternatives
existing. This violates the async-I/O compliance requirement and can cause thread blocking under
load.
Agent Prompt 
## Issue description
The serializer performs synchronous stream I/O (`JsonSerializer.Deserialize(stream, ...)` and `Utf8JsonWriter`-based serialization), which can block threads.

## Issue Context
Compliance requires I/O to be asynchronous where async alternatives exist.

## Fix Focus Areas
- src/Experimental/src/Eventuous.ElasticSearch/Store/ElasticSerializer.cs[13-26]
- src/Experimental/src/Eventuous.ElasticSearch/Store/ElasticSerializer.cs[28-38]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


if (type != typeof(PersistedEvent)) return obj!;

Expand All @@ -31,7 +32,8 @@ public void Serialize<T>(T data, Stream stream, SerializationFormatting formatti
return;
}

var writer = new Utf8JsonWriter(stream);
// Disposing the writer returns its pooled buffers and flushes; it doesn't close the caller's stream
using var writer = new Utf8JsonWriter(stream);
JsonSerializer.Serialize(writer, data, _options);
}

Expand Down
Loading