Stop coherent ctrl port write overwriting the most significant word with unused cache.

[NobleBrutus]

Pull Request Details

Fix bug in fpga/usrp3/lib/rfnoc/utils/ctrlport_reg_rw.v which overwrites the most significant word with zeros from the cache. Fix makes behaviour consistent with lines 154-156.

Description

Line 156:
reg_val[32*(NUM_BYTES/4-1)+b*8 +: 8] <= s_ctrlport_req_data[8*b +: 8];
sets the bits for the word NUM_BYTES/4-1

But line 160 counts up to less than NUM_BYTES/4 which of course includes NUM_BYTES/4-1.
This causes the most significant word to be set to zero (as the cache value is never set) instead of the intended value from line 156.

Which devices/areas does this affect?

Coherent register writes.

Testing Done

Did coherent writes on a custom RFNoC Block on an N320.

Checklist

• I have read the CONTRIBUTING document.
• My code follows the code style of this project. See CODING.md.
• I have updated the documentation accordingly.
• I have added tests to cover my changes, and all previous tests pass.
• I have checked all compat numbers if they need updating (FPGA compat,
  MPM compat, noc_shell, specific RFNoC block, ...)

[github-actions]

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

_{You can retrigger this bot by commenting recheck in this Pull Request}

[NobleBrutus]

Mu understanding is that for simple bug fixes the CLA is not required.

[wordimont]

Thanks for pointing this out! A fix was merged internally and should be pushed public in the near future.