Skip to content

Create ergoplatform-ergo-1905.json (reservation, 500 SigUSD) - #48

Closed
Ergologica wants to merge 1 commit into
ErgoDevs:mainfrom
Ergologica:submission-ergo-1905
Closed

Create ergoplatform-ergo-1905.json (reservation, 500 SigUSD)#48
Ergologica wants to merge 1 commit into
ErgoDevs:mainfrom
Ergologica:submission-ergo-1905

Conversation

@Ergologica

Copy link
Copy Markdown

Type

  • Bounty submission or reservation
  • Automation/code change
  • Generated data update
  • Documentation

Submission Checklist

  • One submissions/*.json file changed
  • contributor matches PR author
  • wallet_address is real, not placeholder
  • status is one of in-progress, awaiting-review, reviewed, paid
  • Completed claims use a GitHub PR URL in work_link
  • Completed claims link merged upstream work — upstream PR is open, not merged yet
  • Paid claims include payment_tx_id and payment_date

Notes

Reservation for ergoplatform/ergo#1905/wallet/payment/send is trying to spend custom scan boxes (500 SigUSD).

Work submitted upstream as ergo#2451 (open, awaiting review): OffChainRegistry.offChainBoxes holds the unconfirmed boxes of all scans, so boxes tracked only by an external application scan were spendable by wallet transactions. A new walletOffChainBoxes (payments scan only) is now used by getBoxesToSpend and getWalletBoxes, while the scan APIs keep seeing their own unconfirmed boxes. Covered by a new property in ErgoWalletServiceSpec.

Will switch this submission to awaiting-review once the upstream PR is merged.

@github-actions github-actions Bot added the duplicate-bounty Another open PR claims same bounty label Jul 31, 2026
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Submission triage

Closing: submission has blocking validation failures.

@github-actions
github-actions Bot requested a review from kushti July 31, 2026 06:42
@Ergologica

Copy link
Copy Markdown
Author

On the duplicate flag: I opened this after implementing and submitting the fix upstream, and I had not noticed #43 — apologies to @beejaygee for the overlap.

For the maintainers' benefit, the current state as I see it: #43 is a WIP reservation from 2026-07-17 with no upstream pull request against ergoplatform/ergo so far, while the implementation for this issue is already submitted and public in ergo#2451 (production fix plus a regression test in ErgoWalletServiceSpec).

I'm happy to defer to whatever the maintainers consider fair here — if @beejaygee has work in progress, they should feel free to take it; my patch stays available upstream to be reviewed on its merits either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate-bounty Another open PR claims same bounty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant