Create ergoplatform-ergo-1905.json (reservation, 500 SigUSD) - #48
Closed
Ergologica wants to merge 1 commit into
Closed
Create ergoplatform-ergo-1905.json (reservation, 500 SigUSD)#48Ergologica wants to merge 1 commit into
Ergologica wants to merge 1 commit into
Conversation
Contributor
Submission triage
Closing: submission has blocking validation failures. |
Author
|
On the duplicate flag: I opened this after implementing and submitting the fix upstream, and I had not noticed #43 — apologies to @beejaygee for the overlap. For the maintainers' benefit, the current state as I see it: #43 is a WIP reservation from 2026-07-17 with no upstream pull request against I'm happy to defer to whatever the maintainers consider fair here — if @beejaygee has work in progress, they should feel free to take it; my patch stays available upstream to be reviewed on its merits either way. |
This was referenced Jul 31, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Submission Checklist
submissions/*.jsonfile changedcontributormatches PR authorwallet_addressis real, not placeholderstatusis one ofin-progress,awaiting-review,reviewed,paidwork_linkpayment_tx_idandpayment_dateNotes
Reservation for ergoplatform/ergo#1905 — /wallet/payment/send is trying to spend custom scan boxes (500 SigUSD).
Work submitted upstream as ergo#2451 (open, awaiting review):
OffChainRegistry.offChainBoxesholds the unconfirmed boxes of all scans, so boxes tracked only by an external application scan were spendable by wallet transactions. A newwalletOffChainBoxes(payments scan only) is now used bygetBoxesToSpendandgetWalletBoxes, while the scan APIs keep seeing their own unconfirmed boxes. Covered by a new property inErgoWalletServiceSpec.Will switch this submission to
awaiting-reviewonce the upstream PR is merged.