Skip to content

Fix / Redesign / Disable ":tornado" #2124

Description

@thatgato

Version channel

Nightly

Loader version

v278

What part of Adonis is this related to?

Command

What happened?

:tornado command does not run.
This issue likely relates to #2090 and how string scripts refuse to run.

However, there is more to this: Fixing the tornado command results in a sound and model-less behavior.
Changing the sound id to something that is accessible fixes the sound issue, however the model appears to have been deleted among the commits somewhere?

The command behaves as this video shows, in it's current "fixed" state: https://streamable.com/vfbl9h

Question: Do we want to merge this "fix" and leave the tornado command functioning like this, or do we straight up disable / remove / rework it?

Steps to reproduce

Run :tornado. Ideally nothing should happen, as the script never runs (something to do with #2090 I think)

Device

Windows

Relevant log output

None. Likely an issue with how Core.NewScript() behaves (see the previously mentioned issue).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ⚡ commandSpecific Adonis commands🐛 bugBugs or broken features

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions