Skip to content

Gate windows-sys dependencies on Windows targets and fix UTF-8 terminal output #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subhramit wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −5
Open

Gate windows-sys dependencies on Windows targets and fix UTF-8 terminal output #45

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8735a56
Gate windows-sys dependency on Windows targets
subhramit Jun 20, 2026
285e673
Fix UTF-8 console output on Windows CLI
subhramit Jun 27, 2026
cd4ee3c
Merge branch 'main' of https://github.com//subhramit/lore into window…
subhramit Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lore-base/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ rand = { workspace = true }
serde = { workspace = true }
uuid = { workspace = true, features = ["zerocopy"] }

# fs
windows-sys = { workspace = true, features = ["Win32_Storage_ProjectedFileSystem", "Win32_Storage_FileSystem", "Win32_System_Diagnostics", "Win32_System_Diagnostics_Debug", "Win32_System_IO", "Win32_Security"] }

# log
chrono = { workspace = true }

Expand All @@ -44,6 +41,10 @@ pin-project = { workspace = true }
rayon = { workspace = true }
tokio = { workspace = true }

# fs
[target.'cfg(target_family = "windows")'.dependencies]
windows-sys = { workspace = true, features = ["Win32_Storage_ProjectedFileSystem", "Win32_Storage_FileSystem", "Win32_System_Diagnostics", "Win32_System_Diagnostics_Debug", "Win32_System_IO", "Win32_Security"] }

[dev-dependencies]
serde_json = { workspace = true, features = ["std"] }

Expand Down
4 changes: 3 additions & 1 deletion lore-client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,15 @@ serde_json = { workspace = true }
thiserror = { workspace = true }
tokio = { workspace = true }
toml = { workspace = true }
windows-sys = { workspace = true, features = ["Win32_System_Console", "Win32_Networking_WinSock"] }

lore = { workspace = true }
lore-base = { workspace = true }
lore-error-set = { workspace = true }
lore-revision = { workspace = true }

[target.'cfg(target_family = "windows")'.dependencies]
windows-sys = { workspace = true, features = ["Win32_System_Console", "Win32_Networking_WinSock"] }

[features]
default = []
oodle = ["lore/oodle"]
Expand Down
4 changes: 3 additions & 1 deletion lore-revision/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,12 @@ lore-proto = { workspace = true }
lore-telemetry = { workspace = true }
lore-transport = { workspace = true }
uuid = { workspace = true, features = ["zerocopy"] }
windows-sys = { workspace = true, features = ["Win32_Storage_ProjectedFileSystem", "Win32_Storage_FileSystem", "Win32_System_Diagnostics", "Win32_System_Diagnostics_Debug", "Win32_System_IO", "Win32_Security"] }
xxhash-rust = { workspace = true }
zerocopy = { workspace = true }

[target.'cfg(target_family = "windows")'.dependencies]
windows-sys = { workspace = true, features = ["Win32_Storage_ProjectedFileSystem", "Win32_Storage_FileSystem", "Win32_System_Diagnostics", "Win32_System_Diagnostics_Debug", "Win32_System_IO", "Win32_Security"] }

[dev-dependencies]
lore-storage = { workspace = true }
serde_json = { workspace = true }
Expand Down
2 changes: 2 additions & 0 deletions lore/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ lore-transport = { workspace = true }
lore-error-set = { workspace = true }
lore-macro = { workspace = true }
lore-notification = { workspace = true }

[target.'cfg(target_family = "windows")'.dependencies]
windows-sys = { workspace = true, features = ["Win32_Networking_WinSock"] }

[build-dependencies]
Expand Down