Repository navigation
Upgrade Aspire to 13.4.2, refresh all dependencies, and document ATS availability - #2
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
EmmittJ
June 4, 2026 13:02
View session
EmmittJ
approved these changes
Jun 4, 2026
EmmittJ
marked this pull request as ready for review
June 4, 2026 13:04
Copilot stopped work on behalf of
EmmittJ due to an error
June 4, 2026 13:06
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Aspire/AppHost integration and overall dependency set to align with Aspire 13.4.2, while adding a cross-language “raw HCL” value-provider escape hatch (TerraformRawExpression) that can flow through Aspire’s expression/value-provider system into the Terraform AST.
Changes:
- Upgraded Aspire (AppHost SDK + Aspire.* packages) to 13.4.2 and refreshed other centrally-managed dependency versions.
- Replaced container image push logic to use
IResourceContainerImageManager.PushImageAsync(resource, ct)instead of the removedIResourceContainerImageBuilder. - Introduced
TerraformRawExpressionwith tests and documentation, and refreshed Verify manifest snapshots to match Aspire 13.4.2 output (no$schemaline).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/EmmittJ.Aspire.Hosting.Terraform.Tests/TerraformRawExpressionTests.cs | Adds unit tests validating raw/unquoted HCL lowering and interaction with ReferenceExpression. |
| tests/EmmittJ.Aspire.Hosting.Terraform.Tests/TerraformPipelineIntegrationTests.TerraformStack_WithParentConfiguration_UsesParentDirectory/aspire-manifest.verified.json | Updates Verify snapshot to match Aspire 13.4.2 manifest output (drops $schema). |
| tests/EmmittJ.Aspire.Hosting.Terraform.Tests/TerraformPipelineIntegrationTests.TerraformStack_WithOutputDirectory_GeneratesFileInSpecifiedLocation/aspire-manifest.verified.json | Updates Verify snapshot to match Aspire 13.4.2 manifest output (drops $schema). |
| tests/EmmittJ.Aspire.Hosting.Terraform.Tests/TerraformPipelineIntegrationTests.TerraformStack_WithComplexConfiguration_GeneratesValidHCL/aspire-manifest.verified.json | Updates Verify snapshot to match Aspire 13.4.2 manifest output (drops $schema). |
| tests/EmmittJ.Aspire.Hosting.Terraform.Tests/TerraformPipelineIntegrationTests.TerraformStack_GeneratesFileInDefaultLocation/aspire-manifest.verified.json | Updates Verify snapshot to match Aspire 13.4.2 manifest output (drops $schema). |
| tests/EmmittJ.Aspire.Hosting.Terraform.Tests/TerraformPipelineIntegrationTests.MultipleAnnotations_ContributeToSingleStack/aspire-manifest.verified.json | Updates Verify snapshot to match Aspire 13.4.2 manifest output (drops $schema). |
| src/EmmittJ.Terraform.Sdk.AppHost/EmmittJ.Terraform.Sdk.AppHost.csproj | Bumps AppHost SDK to Aspire 13.4.2. |
| src/EmmittJ.Aspire.Hosting.Terraform/TerraformRawExpression.cs | Adds a new Aspire value provider to carry verbatim/unquoted HCL into Terraform expressions. |
| src/EmmittJ.Aspire.Hosting.Terraform/TerraformPublishingContext.cs | Teaches module-parameter resolution to lower TerraformRawExpression as TerraformExpression.Raw(...). |
| src/EmmittJ.Aspire.Hosting.Terraform/TerraformProvisioningResource.cs | Migrates container image push to IResourceContainerImageManager and adds support for resolving TerraformRawExpression. |
| src/EmmittJ.Aspire.Hosting.Terraform/README.md | Documents the cross-language expression contract, raw-HCL escape hatch, and ATS attribute availability/analyzer opt-in. |
| playground/getting-started/GettingStarted.csproj | Updates Aspire AppHost SDK and Aspire.Hosting.AppHost dependency to 13.4.2. |
| playground/azure-container-apps/apphost/AppHost.csproj | Updates Aspire AppHost SDK and Aspire.Hosting.* dependencies to 13.4.2. |
| Directory.Packages.props | Refreshes centrally-managed versions (Aspire, testing, Roslyn, SourceLink, OpenTelemetry, etc.). |
Comment on lines
949
to
952
| /// <list type="bullet"> | ||
| /// <item><see cref="string"/>: Returned as-is</item> | ||
| /// <item><see cref="TerraformRawExpression"/>: Lowered to a verbatim (unquoted) HCL expression</item> | ||
| /// <item><see cref="EndpointReference"/>: Resolved via <see cref="ResolveEndpointReference"/></item> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the Aspire stack to 13.4.2 (required for GA), brings every other dependency to its latest stable version, and corrects the README's now-inaccurate note about Aspire Type System (ATS) attributes.
Aspire 13.4.2
Aspire.AppHost.Sdkand allAspire.*package versions (central + playground/AppHost projects) to13.4.2.IResourceContainerImageBuilder. The replacementIResourceContainerImageManager.PushImageAsync(resource, ct)resolves the local image name, computes the registry-qualified remote tag, tags, and pushes internally — collapsing the prior manual tag+push:$schemaline.Other dependencies
Microsoft.NET.Test.Sdk18.6.0,xunit2.9.3,xunit.runner.visualstudio3.1.5,coverlet.collector10.0.1,Verify.Xunit31.12.5.Microsoft.CodeAnalysis.CSharp/.Analyzers5.3.0. SourceLink 10.0.300.Microsoft.Extensions.*10.6.0,OpenTelemetry.*1.15.x.ATS attributes
[AspireExport]/[AspireDto]/[AspireExportIgnore]are present inAspire.Hosting13.4.2; their validating analyzer is opt-in behind theEnableAspireIntegrationAnalyzersMSBuild flag (defaultfalse). README note corrected accordingly.ASPIREEXPORT008on every extension method over the Aspire-exportedIResourceBuilder<T>, and several domain types (TerraformOutputReference, configuration/block types) must first be made ATS-compatible. Scope flagged for a follow-up.