fix: update canonical tag on AJAX navigation - #97
Open
ahuininga-orisha wants to merge 1 commit into
Open
Conversation
emico-bot
force-pushed
the
fix/220254-ajax-canonical-pagination
branch
from
August 14, 2026 11:18
8dd7155 to
0138dff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to EmicoEcommerce/Magento2Tweakwise#389.
The Hyva theme uses its own inline vanilla JS implementation in
navigation-form.phtml(no RequireJS). Without this change the canonical tag would not be updated after AJAX navigation on Hyva storefronts, even with the main module's fix applied.Changes:
src/view/frontend/templates/layer/navigation-form.phtml— addsajaxUpdateCanonical(canonical)method and calls it in thefetch()success handler. Updateshrefon the existing<link rel="canonical">tag if present; does nothing if no canonical tag exists.How to test
Scenario 1 — AJAX navigation updates canonical (Hyva)
tweakwise/layered/enabled = 1,tweakwise/layered/ajax_filters = 1,catalog/seo/category_canonical_tag = 1,tweakwise/seo/paginated_canonical_enabled = 1. Runcache:cleanand redeploy static content.<link rel="canonical">in DevTools — note the initial value.?p=2.Scenario 2 — No canonical tag present, nothing added
catalog/seo/category_canonical_tag = 0. Runcache:clean.<head>.