Implement config validation tests with comprehensive flag combination checks

[Copilot]

Implements test coverage specified in .prompts/test-config-validation.md. Refactors validation logic from command execution to config layer and adds 52 test cases achieving 100% coverage on critical validation functions.

Changes

Validation Refactoring

• Moved flag combination validation from converter.go to ValidateConverterConfig()
• Added 5 validation helpers: required fields, format normalization, flag combinations, filesystem checks, glob syntax
• Prevents invalid combinations like --validate + --recursive, --recursive without --output-dir

Environment Variables

• Added support for 10 converter config env vars (EVR_CONVERTER_*, NEVR_CONVERTER_*)
• Implemented parseBool() helper accepting "true/1/yes/on"

Test Coverage

• Created internal/config/converter_validation_test.go with 52 tests
• Coverage: ValidateConverterConfig 100%, validateRequiredFields 100%, validateFormat 100%, validateFlagCombinations 86.7%, validateFileSystem 79.2%
• Scaffolded 45 additional converter function tests in cmd/agent/converter_test.go (blocked by pre-existing build issues)

Example

Before:

// Validation scattered in runConverter()
if cfg.Converter.Validate && cfg.Converter.ExcludeBones {
    return fmt.Errorf("--validate cannot be used with --exclude-bones")
}
// Basic validation in config
if cfg.Converter.InputFile == "" {
    return fmt.Errorf("input file must be specified")
}

After:

// All validation centralized in config layer
func (c *Config) ValidateConverterConfig() error {
    // 35+ validation rules across 5 categories
    if err := validateRequiredFields(cfg); err != nil { return err }
    if err := validateFormat(cfg); err != nil { return err }
    if err := validateFlagCombinations(cfg); err != nil { return err }
    if err := validateFileSystem(cfg); err != nil { return err }
    if err := validateGlobPattern(cfg); err != nil { return err }
    return nil
}

Notes

Pre-existing build failures prevent testing cmd/agent functions (missing nevr-common/v4/gen/go/apigame/v1, undefined events.NewWithDefaultSensors). Config tests verified working.

Original prompt

implement the test.. .prompts/test-config-validation.md .prompts/test-converter-tier1-critical.md .prompts/test-converter-tier2-high.md .prompts/test-converter-tier3-medium.md

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.