Fix #4142: bypass failing diagnostic fields in exact restart tests - #4145
Closed
johnpaulalex wants to merge 1 commit into
Closed
Fix #4142: bypass failing diagnostic fields in exact restart tests#4145johnpaulalex wants to merge 1 commit into
johnpaulalex wants to merge 1 commit into
Conversation
8 tasks
Contributor
|
Hey @johnpaulalex we already have a different fix that went onto b4b-dev and about to come into master that does this in a different way. See #4136 and #4140. So I'll close this as a wontdo. |
Contributor
|
Closing because we have a different solution for doing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR serves as a stopgap measure to restore passing status to the
all_outputsintegration tests while avoiding permanent, restrictive modifications to the Fortran source code.Currently, 35 diagnostic fields (originally identified in Issue #3661) fail exact restart checks because they lack proper read/write initialization logic. Instead of commenting these fields out in the core Fortran files (which prevents users from ever outputting them), this PR adds them to the
hist_fexcl1namelist exclusion list specifically within theall_outputstestmod.Because the
all_outputstests now effectively bypass these broken fields and pass as intended, theExpectedTestFails.xmloverride for#3661has been removed.(Note: The underlying Fortran restart logic for these fields will be addressed in a follow-up PR, after which this testmod exclusion can be removed, see #4146).
Specific notes
Contributors other than yourself, if any:
CTSM issues resolved or otherwise addressed, if any:
Any user interface changes (namelist or namelist defaults changes)?
Added 35 known-failing diagnostic fields to
hist_fexcl1exclusively inside thecime_config/testdefs/testmods_dirs/clm/all_outputs/user_nl_clmtestmod.Testing planned or performed, if any:
ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs) to pass.Requirements before merge:
all_outputs).