Change "dynamic" to "transient" veg/pfts when referring to landuse data

bld/CLMBuildNamelist.pm

@@ -2564,7 +2564,7 @@ sub setup_logic_surface_dataset {
   $flanduse_timeseries = $nl_flags->{'flanduse_timeseries'};
 
   if ($flanduse_timeseries ne "null" && &value_is_true($nl_flags->{'use_cndv'}) ) {
-     $log->fatal_error( "dynamic PFT's (setting flanduse_timeseries) are incompatible with dynamic vegetation (use_cndv=.true)." );
+     $log->fatal_error( "Transient PFTs (setting flanduse_timeseries) are incompatible with dynamic vegetation (use_cndv=.true)." );
   }
   # Turn test option off for NEON until after XML is interpreted
   my $test_files = $opts->{'test'};

bld/namelist_files/namelist_defaults_ctsm.xml

@@ -2008,7 +2008,7 @@ lnd/clm2/surfdata_esmf/NEON/ctsm5.4.0/surfdata_1x1_NEON_${NEONSITE}_hist_2000_78
 lnd/clm2/surfdata_esmf/NEON/ctsm5.4.0/surfdata_1x1_NEON_TOOL_hist_2000_78pfts_c251023.nc</fsurdat>
 -->
 
-<!-- Dynamic PFT surface datasets (relative to {csmdata}) -->
+<!-- Transient PFT surface datasets (relative to {csmdata}) -->
 
 <!-- When NEON landuse datasets are available uncomment the following for something like this...
      Also change the setting for clm_demand in the namelist_defaults_overall.xml file

bld/namelist_files/namelist_defaults_usr_files.xml

@@ -26,7 +26,7 @@ provided they are in the valid list expressed above.
 <fsurdat phys="clm4_0">lnd/clm2/surfdata/surfdata_${clm_usr_name}_simyr${sim_year}.nc</fsurdat>
 <fsurdat phys="clm4_5">lnd/clm2/surfdata_map/surfdata_${clm_usr_name}_simyr${sim_year}.nc</fsurdat>
 
-<!-- Dynamic PFT surface dataset (relative to ${csmdata}) -->
+<!-- Transient PFT surface dataset (relative to ${csmdata}) -->
 <flanduse_timeseries sim_year_range="constant"  ssp_rcp="hist">null</flanduse_timeseries>
 <flanduse_timeseries                            ssp_rcp="hist">lnd/clm2/surfdata/landuse.timeseries_${clm_usr_name}_simyr${sim_year_range}.nc</flanduse_timeseries>
 <flanduse_timeseries sim_year_range="1850-2000" ssp_rcp="hist">lnd/clm2/surfdata/landuse.timeseries_${clm_usr_name}_simyr1849-2006.nc</flanduse_timeseries>

doc/source/users_guide/setting-up-and-running-a-case/customizing-the-clm-configuration.rst

@@ -291,7 +291,7 @@ The ``$CTSMROOT/cime_config/buildnml`` script already sets the resolution and ma
 
 ``-chk_res`` ensures that the resolution chosen is supported by CLM. If the resolution is NOT supported it will cause the CLM ``build-namelist`` to abort when run. So when either ``preview_namelist``, ``case.build`` or ``case.run`` is executed it will abort early. Since, the CESM scripts only support certain resolutions anyway, in general this option is NOT needed in the context of running CESM cases.
 
-``-clm_demand`` asks the ``build-namelist`` step to require that the list of variables entered be set. Typically, this is used to require that optional filenames be used and ensure they are set before continuing. For example, you may want to require that fpftdyn be set to get dynamically changing vegetation types. To do this you would do the following.
+``-clm_demand`` asks the ``build-namelist`` step to require that the list of variables entered be set. Typically, this is used to require that optional filenames be used and ensure they are set before continuing. For example, you may want to require that flanduse_timeseries be set, so as to get PFTs that change according to a transient landuse dataset. To do this you would do the following.
 ::
 
    > ./xmlchange CLM_BLDNML_OPTS="-clm_demand fpftdyn"
@@ -302,7 +302,7 @@ To see a list of valid variables that you could set do this:
    > cd $CTSMROOT/doc
    > ../bld/build-namelist -clm_demand list
 
-.. note:: Using a 20th-Century transient compset or the ``20thC_transient`` use-case using ``CLM_NML_USE_CASE`` would set this as well, but would also use dynamic nitrogen and aerosol deposition files, so using ``-clm_demand`` would be a way to get *just* dynamic vegetation types and NOT the other files as well.
+.. note:: Using a 20th-Century transient compset or the ``20thC_transient`` use-case using ``CLM_NML_USE_CASE`` would set this as well, but would also use dynamic nitrogen and aerosol deposition files, so using ``-clm_demand`` would be a way to get *just* the transient landuse file and NOT the other files as well.
 
 ``-drydep`` adds a dry-deposition namelist for testing to the driver. This is a driver namelist, but adding the option here has CLM ``build-namelist`` create the ``drv_flds_in`` file that the driver will copy over and use. Invoking this option does have an impact on performance even for I compsets and will slow the model down. It's also only useful when running with an active atmosphere model that makes use of this information.
 

src/biogeophys/PhotosynthesisMod.F90

@@ -1204,7 +1204,7 @@ end subroutine TimeStepInit
   subroutine NewPatchInit (this, p)
     !
     ! For new run-time pft, modify state and flux variables to maintain
-    ! carbon and nitrogen balance with dynamic pft-weights.
+    ! carbon and nitrogen balance with changing pft-weights.
     ! Called from dyn_cnbal_patch
     !
     ! !ARGUMENTS:

src/dyn_subgrid/dynTimeInfoMod.F90

@@ -327,7 +327,7 @@ subroutine set_info_from_year(this, cur_year)
     ! last year for both time_index_lower and time_index_upper, forcing constant weights for the remainder of the
     ! simulation.
     !
-    ! This mechanism permits the introduction of a dynamic pft period in the middle of a
+    ! This mechanism permits the introduction of a period with changing pft weights in the middle of a
     ! simulation, with constant weights before and after the dynamic period.
 
     associate( &

src/dyn_subgrid/dynpftFileMod.F90

@@ -48,7 +48,7 @@ module dynpftFileMod
   subroutine dynpft_init(bounds, dynpft_filename)
     !
     ! !DESCRIPTION:
-    ! Initialize dynamic pft dataset (position it to the right time samples
+    ! Initialize transient pft (landuse) dataset (position it to the right time samples
     ! that bound the initial model date)
     !
     ! !USES:

tools/mksurfdata_esmf/src/mkharvestMod.F90

@@ -1,7 +1,7 @@
 module mkharvestMod
 
   !-----------------------------------------------------------------------
-  ! Make harvest and grazing data to add to the dynamic PFT file.
+  ! Make harvest and grazing data to add to the transient PFT (landuse) file.
   !-----------------------------------------------------------------------
 
   use ESMF
@@ -63,7 +63,7 @@ module mkharvestMod
 
   subroutine mkharvest(file_mesh_i, file_data_i, mesh_o, pioid_o, ntime, rc)
     !
-    ! Make harvest data for the dynamic PFT dataset.
+    ! Make harvest data for the transient PFT (landuse) dataset.
     ! This dataset consists of the normalized harvest or grazing fraction (0-1) of
     ! the model.
     !

tools/mksurfdata_esmf/src/mkpftMod.F90

@@ -50,7 +50,7 @@ subroutine mkpftInit( )
     ! Determine number of PFTs on the natural vegetation landunit, and number of CFTs on
     ! the crop landunit.
     !
-    ! For the sake of dynamic PFTs and dynamic landunits, it helps for the structure of the
+    ! For the sake of transient data (changing PFTs and dynamic landunits), it helps for the structure of the
     ! surface dataset to reflect the subgrid structure that will be used by CLM. Currently
     ! generic crops will always go on the crop landunit, regardless of whether or not we're
     ! using the extra specific crops (so we always run CLM with create_crop_landunit=.true.).

tools/mksurfdata_esmf/src/mksurfdata.F90

@@ -876,7 +876,7 @@ program mksurfdata
      if (ChkErr(rc,__LINE__,u_FILE_u)) call shr_sys_abort('error in calling mkfile_output for LANDFRAC_PFT')
 
      ! -----------------------------------------
-     ! Read in each dynamic pft landuse dataset
+     ! Read in each transient pft landuse dataset
      ! -----------------------------------------
 
      ! Open txt file