Add DATM_YR_END_FILENAME xml variable for PLUMBER2 - #416
Merged
Conversation
10 tasks
Member
|
I did a quick look here. I'm fine with this as long as @ekluzek or someone else from the land group approves. |
ekluzek
added
enhancement
ekluzek
approved these changes
Jul 23, 2026
ekluzek
left a comment
ekluzek
left a comment
Collaborator
There was a problem hiding this comment.
This all looks good and should be brought in.
The settings for DATM_YR_END_FILENAME could be moved from CTSM into here. But, that's a longer term question and it should mainly be done if it would make sense for how CTSM manages the PLUMBER2 sites.
The setting of dtlimit to a high value is what's been done for other cases where we use cycle and the first time sample of the data isn't at 0 UT. But, that's a general problem that should be addressed elsewhere.
Collaborator
|
@billsacks already approved, and I'm giving my approval now. So I'm merging it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
PLUMBER2 site simulations need an xml variable similar to DATM_YR_START_FILENAME to identify the end year of the datm forcing file.
We also need changes to taxmode and dtlimit for the PLUMBER2 HIST compsets.
Specific notes
Contributors other than yourself, if any: NA
CDEPS Issues Fixed (include github issue):
see CTSM PR ESCOMP/CTSM#4092
Fixes #423
Are there dependencies on other component PRs (if so list): ESCOMP/CTSM#4092
Are changes expected to change answers (bfb, different to roundoff, more substantial): No, bfb
Any User Interface Changes (namelist or namelist defaults changes): No
Testing performed (e.g. aux_cdeps, CESM prealpha, etc): Tested within the context of ESCOMP/CTSM#4092
Hashes used for testing: NA